Icons in sub-children about adminthemebundle HOT 12 CLOSED

i like your idea 👍

from adminthemebundle.

I like it too 👍 I pushed your patch as a pull request here #72

from adminthemebundle.

That's a good contribution indeed. I think that we could enhance AdminLTE a bit with this kind of enhancements.

@MartinLyne : do you want to create a pull request on your own, or should we merge @sylvaincombes 's one?

Also, there seems to be a merge conflict with your patch (at least in sylvaincombes's PR). Could you create a pull request upon the latest master branch please?
Also, could you update the documentation according to your changes please?

Thank you!

from adminthemebundle.

Sorry for absence, great, seems @sylvaincombes PR (or my forked repo more likely) suffers the same issue I get whenever I try to modify files via github's editor, I'll make a new branch and edit code/documentation via normal means and make a new PR, see if that works.

from adminthemebundle.

Hi! No problem.
The best way to be to:

1. Clone your fork locally
2. Sync it
3. Create a branch
4. Make your changes, commit, push and create a PR from this branch

This will allow you to be up to date with the master branch and be sure that your PRs will be accepted :)

Thank you for your contribution!

from adminthemebundle.

@chteuchteu Yeah it's much easier locally, I guess github doesn't warn you that forked projects are out of sync

Now I update, i notice that there has been a significant change to the way the sidebar nav works in this commit: 75c1d75

Seems that top-level items with no route can no longer host children, does that look like an oversight I should amend, or is it desired restriction? Probably want to drop into child-bearing code if it has a route or it has children? (I'll give it a go)

from adminthemebundle.

That's unfortunate indeed... I don't know if it is a desired restriction, but anyways: I don't think that we should stick with this restriction.

Could you give it a try please?

from adminthemebundle.

That fix seems to work, I think worst case is we go back to whatever could have happened before, my non-route-with-children examples work okay, I added some top-levels-without-routes-no-children and they display as I think they should.

I'll prep the PR

from adminthemebundle.

Thank you for your work, I just merged the PR.

from adminthemebundle.

Great 🤘 thanks to @MartinLyne @OskarStark @chteuchteu ! (I closed the pull request #72 made from @MartinLyne first patch)

from adminthemebundle.

Brilliant! https://www.youtube.com/watch?v=S65ZzffW-Cw

from adminthemebundle.

👍

from adminthemebundle.