Comments (9)
Actually, avajs/ava#673 might make this discussion moot, as I would rather use it than a skip test.
from eslint-plugin-ava.
Ok, let's defer this discussion until after avajs/ava#673 is resolved.
from eslint-plugin-ava.
I'm 👍 on warning
. I feel skip
is a little bit the same as a TODO
comment. Eventually you want them out, but they can be darn handy to not forget something in the future.
from eslint-plugin-ava.
👍
from eslint-plugin-ava.
👎
In my day job, my colleagues and I often use .skip
and only
to temporarily run tests only on what we want to fix/add. At the end of the day, we remove them, commit and push. But we had to add additional tools (we use Mocha for most projects) to abort the push if they remained somewhere because we often forgot to remove them.
We're used to: "If it passes all tests, it's all good", and warnings would be ignored in the buttload of text generated by all the different test phases. I have the same mentality when developing modules (though there is a lot less text, so I could maybe see it in the console). Also: a CI wouldn't catch those, and then who knows how long it would take before someone notices it.
I don't mind re-enforcing it in my projects, but to me, it makes sense to keep it as an error in quite some cases.
from eslint-plugin-ava.
You can always overwrite it in the config rules. It's more about "what's the best default for this rule".
from eslint-plugin-ava.
You can always overwrite it in the config rules. It's more about "what's the best default for this rule".
I agree, but I think that allowing omitted tests is a rarer case than not allowing omitted tests. If it's an error, it can be a life-saver at best, a nuisance at worst?
from eslint-plugin-ava.
#673 is a good alternative to this.
from eslint-plugin-ava.
I guess it depends whether you lint before or after running tests. If before then it should be configured to be a warning, else you can't run your tests to begin with.
from eslint-plugin-ava.
Related Issues (20)
- no-ignored-test-files caches results too aggressively. HOT 1
- Edge-case crashes & false-positives in no-statement-after-end with unreachable statements
- no-identical-title crashes if title is missing HOT 4
- `use-test`: Allow import statements without default specifier HOT 1
- Ensure AVA is specified as a dev dependency HOT 1
- `no-identical-title` crash HOT 2
- Support test.macro()
- No checks with typed context HOT 2
- Allow concatenation when ensuring assertion message is a string HOT 1
- Fix integration tests
- Support ESLint 8.x HOT 1
- Prefer `t.true(x)` over `t.is(x, true)` HOT 1
- Enable `eslint-plugin/prefer-placeholders` rule
- cannot destructure property 'type' or 'node' as it is undefined HOT 2
- Some rules do not fail gracefully: ava/prefer-t-regex HOT 1
- `prefer-t-regex` fails with `t.is()` with a single argument
- `ava/use-test` allow inline type imports
- `no-import-test-files` is slow
- `ava/use-test` does not allow `anyTest` in `.cts` and `.mts` files
- TypeError: Cannot destructure property 'type' of 'node' as it is undefined.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-plugin-ava.