no-identical-title and template strings about eslint-plugin-ava HOT 5 CLOSED

Same if I try 'decodes ' + title actually 😉

from eslint-plugin-ava.

Same if I try 'decodes ' + title actually

Already covered: https://github.com/sindresorhus/eslint-plugin-ava/blob/master/test/no-identical-title.js#L50

It should probably recognize the title is a template string and is most likely not a duplicate.

Yup, it should work as 'decodes ' + title.

from eslint-plugin-ava.

@sindresorhus what do you mean by covered?

from eslint-plugin-ava.

Already covered: https://github.com/sindresorhus/eslint-plugin-ava/blob/master/test/no-identical-title.js#L50

Except @novemberborn is suggesting that test is wrong.That should be valid. Computed titles should be accepted by the linter. (Unless we want to try to do static analysis to determine the computed values, to which I say... 👎).

If we want to guard against computed titles, that should be done in AVA at runtime (just because it is way easier to do so).

from eslint-plugin-ava.

Oops, I somehow thought it was in the valid section.

That should be valid. Computed titles should be accepted by the linter.

👍

Unless we want to try to do static analysis to determine the computed values

👎

from eslint-plugin-ava.