Git Product home page Git Product logo

Comments (7)

isamu-takagi avatar isamu-takagi commented on August 26, 2024 1

I think we need rules to clarify the interface for the following reasons.

  • It's often difficult to know what parameters/topic the node has because the interface definitions (e.g. create_subscription) are scattered in the code.
  • There is no way to know which topics are public or private in the launch file.
  • A mixture of the default values in the source code and the remap values in the launch file.

from autoware-documentation.

kenji-miyake avatar kenji-miyake commented on August 26, 2024 1

Not a strict rule, but there's a guideline to write good code, called Object Calisthenics. This is a pretty strict guideline, so it is not necessary to precisely follow, but it helps to write testable, reusable, and extensible code.

In that case, it's better to link the document as a reference.
Regarding some important techniques can be picked up and be written in our guidelines. (If there are no license issues.)

Anyway, whatever we adopt, it would be better to have some tips or guidelines for writing good code other than coding rules.

Yes, of course. I'm preparing it.

from autoware-documentation.

IshitaTakeshi avatar IshitaTakeshi commented on August 26, 2024

Not a strict rule, but there's a guideline to write good code, called Object Calisthenics. This is a pretty strict guideline, so it is not necessary to precisely follow, but it helps to write testable, reusable, and extensible code.

from autoware-documentation.

IshitaTakeshi avatar IshitaTakeshi commented on August 26, 2024

Anyway, whatever we adopt, it would be better to have some tips or guidelines for writing good code other than coding rules.
By accumulating knowledge and tips and publishing them, we can improve our product quality and contribute to open source communities.

from autoware-documentation.

stale avatar stale commented on August 26, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

from autoware-documentation.

kenji-miyake avatar kenji-miyake commented on August 26, 2024

I think I can write some more documents this month.

from autoware-documentation.

stale avatar stale commented on August 26, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

from autoware-documentation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.