Git Product home page Git Product logo

Comments (5)

hgao-astro avatar hgao-astro commented on June 30, 2024 1

Thanks for the prompt reply. Let me give it a try and see if it works as expected. btw, I forgot to mention that I used a perturbation scale = 0.1 to achieve successful face-on fits, and have not yet evaluated the impact on computation time.

from autoprof.

hgao-astro avatar hgao-astro commented on June 30, 2024

btw, during initialization, the optimization of global ellipticity also involves _inv_x_to_eps and _x_to_eps.

res = minimize(
lambda e, d, r, p, c, n, msk: sum(
list(
_fitEllip_loss(_x_to_eps(e[0]), d, r * m, p, c, n, msk)
for m in np.linspace(0.8, 1.2, 5)
)
),
x0=_inv_x_to_eps(ellip),
args=(
dat,
circ_ellipse_radii[-2],
phase,
results["center"],
results["background noise"],
mask,
),
method="Nelder-Mead",
options={
"initial_simplex": [
[_inv_x_to_eps(ellip) - 1 / 15],
[_inv_x_to_eps(ellip) + 1 / 15],
]
},
)

I have no evidence this will cause an issue. Please weigh in on this. Thanks!

from autoprof.

ConnorStoneAstro avatar ConnorStoneAstro commented on June 30, 2024

Hi @hgao-astro,

Wow, this is great work! To me this seems clearly better for face-on galaxies. My only concern is for edge-on systems with ellip close to 1. In that case the shape becomes very sensitive to small changes in the ellipticity and so part of the remapping of _x_to_eps was to effectively decrease the step size near edge-on. Perhaps we could get the best of both worlds by adding an if statement which does the _x_to_eps scheme when ellip > 0.5 and doing your reflection scheme when ellip < 0.5. Both method are basically equivalent around ellip = 0.5 so it should be a pretty smooth transition. What do you think about that?

I agree for the initialization it is fine to just keep it since its more the optimization that encounters the issue.

from autoprof.

hgao-astro avatar hgao-astro commented on June 30, 2024

Thanks for your patience. I have been occupied by job searching these days. I will try to get to it in Jan. 2024.

from autoprof.

ConnorStoneAstro avatar ConnorStoneAstro commented on June 30, 2024

@hgao-astro Good luck with your job search! I look forward to hearing from you in the new year!

from autoprof.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.