Git Product home page Git Product logo

Comments (5)

gregneagle avatar gregneagle commented on May 30, 2024

Looks less nasty, though it's still doing unnecessary crap in the postinstall.

At least it's not installing in the installcheck and it doesn't try to write to the current user's home.

from homebysix-recipes.

gregneagle avatar gregneagle commented on May 30, 2024

Some issues still with the "enterprise-friendly" package's post-install:

  1. the postinstall script kills the installer process, which causes an error to be reported:
#kill installer
SAVED_STATE_FILE=~/Library/Saved\ Application\ State/com.apple.installer.savedState/windows.plist
installer_pid=$(ps -x -a -o pid -o command | grep "/System/Library/CoreServices/Installer.app"\
| while read each_p
do
    echo "$each_p"
done \
| grep "MacOS" | cut -d " " -f 1)

echo "installer pid: $installer_pid">>$LOG_PATH
echo "["$(date)"]installer saved state: $SAVED_STATE_FILE">>$LOG_PATH

if [[ -f  $SAVED_STATE_FILE ]] ; then
    rm -rf "$SAVED_STATE_FILE"
    ret=$?
    echo "file exist, delete it: $ret">>$LOG_PATH
fi

if [ $installer_pid > 0 ] ; then
    kill -9 $installer_pid
else
    installer_pid=$(ps -ef | grep "/System/Library/CoreServices/Installer.app"\
    | while read each_p
    do
        echo "$each_p"
    done \
    | grep "MacOS" | cut -d " " -f 2)

    echo "installer pid 2: $installer_pid">>$LOG_PATH
    kill -9 $installer_pid

    installer_pid=$(ps -ef | grep "/System/Library/CoreServices/Installer.app"\
    | while read each_p
    do
        echo "$each_p"
    done \
    | grep "MacOS" | cut -d " " -f 3)

    echo "installer pid 3: $installer_pid">>$LOG_PATH
    kill -9 $installer_pid
fi
  1. The postinstall removes !!!! any preexisting /Library/Preferences/us.zoom.config.plist -- so if you are managing configuration preferences for Zoom by placing/managing that file, the installer kills it.

  2. The postinstall launches the Zoom application. If this is supposed to be a "mass-deployment" package, I'm sure the admin wants Zoom to be launched on every single machine in their fleet as they update them.

#launch zoomus app
echo "find login user: $login_user, $ver">>$LOG_PATH
#if [ $ver != "10.11" ] ; then
#	su $b -c "open $2/Contents/MacOS/ZoomPresence"
#else
#When auto update on 10.11, system always return "The application cannot be opened because its executable is missing." while starting ZR with su command. 
#The su command will success after about 8 seconds after auto update.
for (( i = 0; i < 10; i++ )); do
	start_zr=$(su $login_user -c "open $2")
	ret=$?
	echo "start zr status: $start_zr, $ret">>$LOG_PATH

	if [ $ret -eq 0 ]; then
		break
	fi

	sleep 2
done

So I'm not convinced this is an actual improvement over the current Autopkg recipes for Zoom, which already deal with some of the installation issues.

from homebysix-recipes.

ygini avatar ygini commented on May 30, 2024

@gregneagle thanks for your feedback on this. I will try to work with them to fix this.

from homebysix-recipes.

gregneagle avatar gregneagle commented on May 30, 2024

Any update/improvement here? I was trying to figure out why I had started some Zoom_IT recipes but never finished them...

from homebysix-recipes.

homebysix avatar homebysix commented on May 30, 2024

Merged #177.

from homebysix-recipes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.