Performance issue caused by wpcom_vip_add_role_caps about wpcom-legacy-redirector HOT 5 CLOSED

Yikes, you're right! Thanks for reporting, @mslinnea.

Originally added here by @mikeyarce before the class got moved to it's own file.

Code is now here.

from wpcom-legacy-redirector.

We fixed this performance issue by adding this to theme code:
remove_action( 'init', [ 'WPCOM_Legacy_Redirector', 'register_redirect_custom_capability' ] );

As for fixing this in the plugin, I think this should only run during plugin activation or during a plugin upgrade routine. It's important to make sure this only runs in a limited and controlled manner.

from wpcom-legacy-redirector.

When plugins are activated by code on VIP, there is no plugin activation or upgrade routine.

But, we should be able to protect against by using the approach at https://docs.wpvip.com/how-tos/customize-user-roles/.

from wpcom-legacy-redirector.

We experienced an issue with the customize-user-roles code suggestion. The issue is that when the version is changed, all page requests will attempt to update the option at the same time. On a site with a lot of traffic, this caused a brief site outage as the database experienced an overload. We moved this update option code to a CLI command so that it only runs once. Alternatively, it could be limited to running only in the admin, which most likely wouldn't create enough requests to overload the database.

from wpcom-legacy-redirector.

@mslinnea Please see #94 - the hook is now admin_init, the capability registration incorporates a version check, and we've added some unit tests to have more confidence that everything is working.

from wpcom-legacy-redirector.