Git Product home page Git Product logo

Comments (3)

valeriuflorescu16 avatar valeriuflorescu16 commented on May 23, 2024

The main difference here is that the in the first instance, the generic type is defined at method level - each time you call testFunction, you can pass in a different type (one that is valid, so it has to extend IBase, which it does in your scenario so everything works well).

In TestClass2, the generic parameter is defined at class level, which is where the issue lies. Once you create an instance of TestClass2, the generic type is fixed for that instance. So if you were to replace const testClass2 = new TestClass2(); with const testClass2 = new TestClass2<IDiscriminator>(); then you would see the type error on the call of the function with BaseModel, and the second one would be fine.

So basically, you have more flexibility when defining the generic parameter at method level. 👍

from mongoose.

github-actions avatar github-actions commented on May 23, 2024

This issue is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days

from mongoose.

vkarpov15 avatar vkarpov15 commented on May 23, 2024

The issue is that, while X extends IBase, there's no guarantee that mongoose.Model<X> extends mongoose.Model<IBase> in the following code.

class TestClass2<X extends IBase> {
  public testFunction(M: mongoose.Model<X>) {
    console.log(M);
  }
}

I'd recommend @valeriuflorescu16 's approach: define the generic at the method level, not the class level. TypeScript doesn't have a way for us to tell the compiler that mongoose.Model<IDiscriminator> extends mongoose.Model<IBase>.

from mongoose.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.