Git Product home page Git Product logo

Comments (3)

tillig avatar tillig commented on July 27, 2024

Perhaps it would be good to understand more about your pain points so we know what changes are good to make. The README shows some pretty simple usage that doesn't feel too heavy-handed. Some of the other changes noted here are... Maybe not things we want to support in this library.

For example, the notion of cleaning folders out. There's a lot to that if we want to offer it as part of a library. The output folder location has to be configurable. We need to handle issues with permissions, which includes issues with restricted environments that don't have rights to write files. We have to think about managing image file size and potentially stop the diagnostics from filling up the disk.

That's why we provide the ability to write these files but we don't include all the stuff to manage the folder and contents and all. We don't have the bandwidth to own, maintain, test, and support all those use cases.

You'll also notice in core Autofac that we will scan assemblies you've loaded and do registrations, but we don't own all the load contracts and the actual assembly loading ourselves. There are too many variables there to "package all that up" and maintain it at the levels our users will expect.

I am a bit interested in what we might be able to do to help with the async case, but if that's just forking a process or thread to do the image write behind the scenes... I'm not sure we want to own or orchestrate that at the library level, either.

If these are things you really want in a library, though, we do encourage the community to add their own extension libraries out there that they publish and support outside of Autofac. And if there's something we have that stops the extension from being written, like an API you need, that's definitely something we can look at enhancing.

Let me know what you think.

from autofac.diagnostics.dotgraph.

dunnodepends avatar dunnodepends commented on July 27, 2024

I agree: looking back, I see I actually created an algorithm (I did not even allow passing paths by adding app-extension parameters), but I did not analyze if the same can be achieved any easier with API-changes, or can be packed-up as-is as a third-party extension. The current model always generates DOT code (even noise from how Microsoft classes are wired), which fills-up the folders - so this change was initially undertaken to each: (1) to automatically generate the diagrams from DOT code, which led to (2) clean the folders between runs, and the slowness to application startup led to (3) generate diagrams concurrently. Enjoy the holiday weekend!

from autofac.diagnostics.dotgraph.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.