Certificates not saved about lua-resty-auto-ssl HOT 7 CLOSED

Was this fixed by explicitly setting the redis port (related to #9)? Or are you still experiencing problems?

This does uncover a compatibility issue between this letsencrypt.sh succeeded, but certs still missing from storage - trying to manually copy edge-case and compatibility with the latest letsencrypt.sh updates (from #7). However, I think that edge-case is only hit if something with the storage doesn't work as expected earlier on, so that's why I'm wondering if specifying a port on the redis adapter fixed this issue for you. If not, let me know, since I think there may still be something else going on with the storage.

In any case, we do need to fix our compatibility with the latest letsencrypt.sh client when dealing with this edge-case. I'll also try to add some better tests around this scenario and some better error handling. Thanks for catching this!

from lua-resty-auto-ssl.

No, #9 did not fix my problems. Im also noticing that i get the following output after clearing my redis and recreating my nginx-container:

Processing domain.com
+ Checking domain name(s) of existing cert... unchanged.
+ Checking expire date of existing cert...
+ Valid till Oct 17 06:11:00 2016 GMT (Longer than 30 days). Skipping renew!

But I'm still getting the error certs still missing from storage. Where is he getting the certificates from then?

I think the cause of not saving to redis is the error about the unbound variable.

I'm going to investigate more next week. Because it would be really cool if this would work correctly!

from lua-resty-auto-ssl.

Okay, I think this might still be related to the original Redis port issue that caused the failure in storing the data. I've fixed the issue around "certs still missing from storage" in master, which I believe should resolve this issue. I'll try to get v0.8.3 pushed to luarocks later today with those fixes.

Alternatively, if you'd like to test this theory now, you could try clearing your redis data and wiping the contents of /etc/resty-auto-ssl/letsencrypt/certs on any of your machines. That should really reset things so a new certificate will be registered and stored in redis with your port fix in place (basically, as long as the previous cert is present in /etc/resty-auto-ssl/letsencrypt/certs, you're going to be hitting the "certs still missing from storage" bug in v0.8.2). Or again, if you want to wait until v0.8.3 is out (hopefully later today), I believe upgrading to that should fix all this.

Sorry for all the trouble caused by the typo around the redis port! But thanks for reporting this and helping debug.

from lua-resty-auto-ssl.

I saw your commits. I will try to test this as fast as possible as it is released.

No problem, thanks for your quick replies!

from lua-resty-auto-ssl.

@gjongenelen: Okay, I just pushed v0.8.3. Can you try upgrading to this version via luarocks? I think it should hopefully fix things in your current installation. But please let me know if you're still running into any issues.

from lua-resty-auto-ssl.

I tested it and it looks like it is working properly.

Thank you very much. This project is saving me a lot of money!

from lua-resty-auto-ssl.

Perfect, glad that did the trick. Thanks for your patience and help in uncovering these couple of bugs!

from lua-resty-auto-ssl.