Unable to recovery from temporarily unavailable discovery document about node-oauth2-jwt-bearer HOT 4 CLOSED

@adamjmcgrath, I could test your change in the meantime with express-oauth2-jwt-bearer 1.4.1 and can confirm that the isssue is solved. Thanks very much for your support.

from node-oauth2-jwt-bearer.

Hi @AugustusKling - thanks for raising this

Yep, you're right - we should retry the discovery after failures (and a discovery cache max age would be a good idea too)

from node-oauth2-jwt-bearer.

Hi Adam,

thanks for the prompt response. The max age seems like a good idea and it can maybe even be derived from the cache headers.

To me it would also make sense to check the retrieved discovery document for completeness before accepting it as cachable. Whilst not having a jwks_uri or similar is clearly not something a server should do, a few checks would help to make the code more resilient against unforseen network issues or server misconfigurations.

from node-oauth2-jwt-bearer.

@adamjmcgrath, the attached PR allows the library to recover from unavailable discovery documents. It does not address anything cache related.

I probably won't have time to reply the next days. Feel to modify and use the code in any way you want.

from node-oauth2-jwt-bearer.