Comments (5)
I'm down with this idea. We can use the same image for our own CI/CD.
The one we are currently using for vCurrent CI/CD can be found here
FROM circleci/node:8.11.3-browsers
RUN sudo chown -R circleci /usr/local
RUN npm i -g npm istanbul http-server codecov protractor gulp jspm && \
webdriver-manager update
RUN sudo apt-get update && \
sudo apt-get install -y wget
RUN wget -O ~/ChromeSetup.deb "https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb" && \
sudo dpkg -i ~/ChromeSetup.deb; sudo apt-get -fy install && \
rm ~/ChromeSetup.deb
Of what would you like to have different versions installed, though? The cli?
How about different versions of node, webpack and whatnot? I'm a bit worried about a potential explosion of combinations of versions here. We do need a solid, justified decision on this that makes an acceptable trade-off between flexibility and maintainability.
from docker.
Please correct me if I am wrong 🙏
How about different versions of node, webpack, and whatnot? I'm a bit worried about a potential explosion of combinations of versions here.
I couldn't agree more with what you are worried about, and think there is a misunderstanding of my statement. I did not mean to have a docker file per webpack versions or any other dependencies.
We can use the same image for our own CI/CD.
Exactly, what I meant is to have a docker image in which we have what you just have here + Aurelia-CLI
, no more no less.
The only thing by my suggestion is that we could have a docker image with different tags, based on the version of aurelia-cli
, for instance, aurelia/cli:1.0.1
and if later we deliver a newer version of the CLI then aurelia/cli:2.0.0
. And instead of putting that docker file/image in a repository where everyone should make a copy/paste, we just deliver it on docker hub for better accessibility. (Everybody who even wants to start with docker knows to check docker hub first for an image, rather than a repository in GitHub)
I think this brings better support for dockerizing aurelia apps and does not bring that much of maintainability.
from docker.
Alright, understood. What do you think about this existing docker image that we already have for CircleCI? We could add aurelia-cli to that, do some automated tagging magic to get a version per aurelia-cli version and we would essentially be done, right?
from docker.
Yes, It looks to be fine, just need the aurelia-cli and tagging; however,
may I have some time to use it with different approaches and configurations that are existed in the cli?
And as far as my knowledge allows me I'll try to come up with a PR if required.
from docker.
Absolutely! So for any viewers: we just discussed this on discord and it turns out there's a little bit more to it (mostly from an automation point of view). We agreed that @shahabganji will open a PR and take things from there.
I'm very excited about this and am looking forward to working together on this one as well: aurelia/cli#1127
Let's make a beautiful docker integration story :)
from docker.
Related Issues (1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docker.