Git Product home page Git Product logo

Comments (9)

jods4 avatar jods4 commented on May 18, 2024

I have a minimal repro, it requires several conditions to trigger the bug, notably nested lambdas.
This breaks Edge 14.4393:

function g(cb) { return g() }
let f = ({ x }) => g(() => x);
f({ x: 42 }); // should return 42 but throws "use before declaration".

from bootstrapper.

jods4 avatar jods4 commented on May 18, 2024

Found a relevant Chakra bug: chakra-core/ChakraCore#2606.
It was opened 5 days ago, I guess it is a recent update. :(

from bootstrapper.

niieani avatar niieani commented on May 18, 2024

We don't need the lambda, we can use function notation if it's going to help, since we only use the scope anyway (no this calls). I'd say we can re-release with a workaround.
Good catch, by the way!

from bootstrapper.

jods4 avatar jods4 commented on May 18, 2024

The bug is not hard to work around as it's very sensible to syntax. Even just adding braces (block) make it vanish.

If we publish a fix the hardest part is making sure minifiers don't simplify the syntax back to broken. For instance, if we add braces or function I would expect a minifier to remove them...

It was not a hard catch as unfortunately now Aurelia ES6 does not run at all in Edge. 😦

from bootstrapper.

jods4 avatar jods4 commented on May 18, 2024

@EisenbergEffect do you want to publish a fix? I can PR one if you want to.

from bootstrapper.

EisenbergEffect avatar EisenbergEffect commented on May 18, 2024

Oh, definitely. If you send a PR I'll get it out today.

from bootstrapper.

jods4 avatar jods4 commented on May 18, 2024

@EisenbergEffect The fix is in the linked PR, it works for me.

from bootstrapper.

EisenbergEffect avatar EisenbergEffect commented on May 18, 2024

Merged.

from bootstrapper.

EisenbergEffect avatar EisenbergEffect commented on May 18, 2024

Release coming in a few minutes.

from bootstrapper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.