Comments (4)
Thank you.
I will take a look in the next days and have a think about it.
@NlL5 feel free to chip in ;)
from osm-tile-proxy.
Ah I see. I did not notice this, because I only integrated TileProxy into our application and our application sends Access-Control headers on its own.
Since the TileProxy class already has the setReferrer() method, I think it would make sense to also set these as headers.
Idk if you already planned this @jhit, but for extensibility and readability, I think it would be nice to create a protected method "sendHeaders()" or so that is called by the handle() method.
from osm-tile-proxy.
I have not implemented anything yet. I just added the header() call to my index.php to solve my problems.
I agree on encapsulating the headers in a private function. Would you also move
osm-tile-proxy/src/TileProxy.php
Lines 306 to 309 in 0c2e18f
from osm-tile-proxy.
Good point. Though, I think these should stay, since we probably do not want them in the other if-else-branches, or the error codes get cached or something.
from osm-tile-proxy.
Related Issues (1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from osm-tile-proxy.