Git Product home page Git Product logo

Comments (4)

augmentedlogic avatar augmentedlogic commented on May 29, 2024

Thank you.

I will take a look in the next days and have a think about it.

@NlL5 feel free to chip in ;)

from osm-tile-proxy.

NlL5 avatar NlL5 commented on May 29, 2024

Ah I see. I did not notice this, because I only integrated TileProxy into our application and our application sends Access-Control headers on its own.

Since the TileProxy class already has the setReferrer() method, I think it would make sense to also set these as headers.

Idk if you already planned this @jhit, but for extensibility and readability, I think it would be nice to create a protected method "sendHeaders()" or so that is called by the handle() method.

from osm-tile-proxy.

jhit avatar jhit commented on May 29, 2024

I have not implemented anything yet. I just added the header() call to my index.php to solve my problems.

I agree on encapsulating the headers in a private function. Would you also move

header("Expires: " . $exp_gmt);
header("Last-Modified: " . $mod_gmt);
header("Cache-Control: public, max-age=" . $this->option_ttl);
header ('Content-Type: image/'.$current_style->getImageFormat());
to this function?

from osm-tile-proxy.

NlL5 avatar NlL5 commented on May 29, 2024

Good point. Though, I think these should stay, since we probably do not want them in the other if-else-branches, or the error codes get cached or something.

from osm-tile-proxy.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.