incompatibility with Copper Rail about minecraft-cart-engine HOT 5 CLOSED

Heya, I just checked it and the mod in question is also overriding the function moveOnRail: https://github.com/iluha168/MCTheCopperRail/blob/main/src/main/java/com/thecopperrail/mixin/AbstractMinecartMixin.java#L23C20-L23C30

They need to change their mod.

If there was even a possible way it could be fixed on this side, I would accept pull requests as long as they don’t negatively impact performance for people who don’t use that other mod.

from minecraft-cart-engine.

I contacted the Copper Rail developer and he told me this:

iluha168/MCTheCopperRail#2 (comment)

from minecraft-cart-engine.

@peow Thank you for the reporting, but it seems like the mods will never be compatible, sorry!

(The other mod author doesn’t seem willing to learn how the overwrite in this mod works.)

from minecraft-cart-engine.

@audaki This is fixable, but it's not going to be an easy fix.

Since you're cancelling the entire moveOnRail method if certain conditions are met, any other mods that try to inject into this method are just met with a no longer existing method.

To fix this, you would need to inject code using mixin only into the necessary parts, without removing the original moveOnRail method.

from minecraft-cart-engine.

@Blockmeska I’d love to see the pull-request for this 😇

Since the "necessary parts" are literally the whole function, it’s why the whole function is overwritten.

from minecraft-cart-engine.