Git Product home page Git Product logo

Comments (2)

extremecoders-re avatar extremecoders-re commented on July 17, 2024

The patch is in place to support Ubuntu 18.04 which defaults to Python2 for the python command. 18.04 goes out of support on April and we should be good to remove the patch then. Besides explicitly referring to Python 3 doesn't harm IMO :)

from firmware-analysis-toolkit.

ddorando avatar ddorando commented on July 17, 2024

Yeah.
This is either about removing a patch which isn't really needed after Ubuntu 18.04 goes EOL (and thus making it kinda redundant to leave it in), or keeping the explicitness that already is there.
In case there isn't any OS that FAT should support supporting python 2 I'd personally suggest to remove it. Just to save a few lines of code and get that tiny bit closer to plain upstream firmadyne.

I know this isn't doing much of anything at this point right now, though IMHO we should keep as close to plain firmadyne as possible to avoid any possible confusion.

from firmware-analysis-toolkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.