Git Product home page Git Product logo

Comments (12)

Djtpj avatar Djtpj commented on June 12, 2024 2

I can confirm, @atticuscornett is who he says he is. He contacted me on another platform to inform me. He is the primary administrator of this repo.

from atmosweather.

atticuscornett avatar atticuscornett commented on June 12, 2024 1

I do not have a PGP key for commits at this time - may set one up in the near future. As for verifying my identity, @Djtpj is probably the most suitable person as he has contributed to this repo, I have worked with him on other another repo (mimacro), and I have numerous other lines of contact with him. If this works for you, I will ask him to confirm my identity on this strand.

Thanks for your patience with me - this is my first and only app I've ever done app signing for so I've got a lot to learn and this shouldn't happen again in the future. Happy holidays!

from atmosweather.

atticuscornett avatar atticuscornett commented on June 12, 2024 1

Thanks again for your patience!

from atmosweather.

atticuscornett avatar atticuscornett commented on June 12, 2024

My apologies - I added a warning to the website, but I forgot to add one to the release notes. To be honest, I am not entirely sure why the signature has changed - I believe it has to do with the migration from Cordova to CapacitorJS. I am using the same key file as previous versions and that is the only thing that has changed relating to Android building.

from atmosweather.

IzzySoft avatar IzzySoft commented on June 12, 2024

Funny. Then nothing should have changed. Can you test what happens if you sign an APK manually? And then maybe also list the keys in your keystore (not that Capacitor just created a new key)? I'm no Android dev and have no idea how Capacitor works, maybe you can configure that (first thing I'd look for is the "alias" defined for the key to use – especially if the keystore holds more than one key). It would be much preferable to stick with the original key, for obvious reasons.

from atmosweather.

atticuscornett avatar atticuscornett commented on June 12, 2024

I should clarify - I build the app manually using Android Studio. However, CapacitorJS uses ProGuard (and adds quite a few Gradle files) and I am unsure how that effects building the app. I will look at the keystore and double check that there aren't multiple keys in it.

from atmosweather.

atticuscornett avatar atticuscornett commented on June 12, 2024

After investigating further, it appears that the current version of Atmos Weather is using the correct keystore and the keystore only has one key. The keystore has not been modified since August of 2022 so nothing should have changed. I can only assume that I had somehow been signing with the incorrect keystore for all versions of Atmos before April. (This is made more confusing by the fact that I don't know what keystore I could have been using before, as the only other keystore on my computer was an incomplete test file with missing information from 2021.)

Also, I remembered that I had to uninstall and reinstall Android Studio a few weeks ago to get it to update properly, and that meant I had to reconfigure app signing. This is probably when the app signature changed.

TLDR: I had been using an unknown incorrect app signature for months and just fixed it with the latest releases. I do not know how I had been signing previously so I cannot revert to the old signature.

from atmosweather.

IzzySoft avatar IzzySoft commented on June 12, 2024

Oof. That makes it tricky. If I understand correctly, that "other" keystore is no longer available to you? For some background of my question, please see: How to keep your key safe and what measures to take for the event of loss?

from atmosweather.

atticuscornett avatar atticuscornett commented on June 12, 2024

That is correct, I can no longer access the other keystore - I had created it simply to learn how to make a keystore, and as such, took no precautions to backup the file or the keystore password. It was never supposed to be used for actual app signing. I do have backup copies and information for the correct keystore, but that is unfortunately of no help because it seems I have not been using it previously.

from atmosweather.

IzzySoft avatar IzzySoft commented on June 12, 2024

That's bad. Does any of the other verification methods work? You didn't sign your commits, so that's no option either. We didn't establish any separate secure communications channel either. That would leave a person we both know to trust confirming it's really you. No offense meant, but someone could have taken over your Github account and impersonate you.

Do you have a PGP/GPG key? Then I'd strongly recommend you at least start using it for signing your commits (or at least the releases) from know on. Is it signed by someone who could act as your "proof"? Even better then. If we have no way for verification, it becomes tricky…

We'll find a way. But for the next 5..6 days I won't be able to attend the issue as I'm "occupied otherwise". We'll see then in the last days of this year, starting around next Thursday.

from atmosweather.

IzzySoft avatar IzzySoft commented on June 12, 2024

First apologies for the delayed response, I was visiting family over the holidays…

For reference: this is the related chapter from the git book, explaining how to set up a key and signing. And yes, if @Djtpj could confirm, that would help.

Meanwhile, thanks for your wishes – and my wishes in return: may the coming year bring you lots of real good things and happenings!

from atmosweather.

IzzySoft avatar IzzySoft commented on June 12, 2024

Thanks @Djtpj – updates enabled again then and the new certificate hash white-listed. v2.0.0 should show up with the next sync around 7 pm UTC.

@atticuscornett you might wish to pick a badge to link to your app in my repo e.g. from your Readme then 😃

from atmosweather.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.