Support for rules from eslint plugins about linter-eslint HOT 9 CLOSED

I first need an answer to eslint/eslint#1450

from linter-eslint.

+1

Any progress so far? It's blocking me using any eslint plugins since linter-eslint crashes trying to read my .eslintrc…

from linter-eslint.

I am sorry to say that I did not make any progress recently. For now, I have no idea of how to do it properly because of how plugins are loaded. I must think about it a bit more.

from linter-eslint.

I can imagine the difficulties: The plugins (incl. versions) are defined in a project (directory) and can't be known beforehand, so you'd have to install them when reading a project's .eslintrc and even store them per-project. That's not easy and probably a bad solution anyway.

Is there a chance you might parsing the .eslintrc a bit more robust, e.g. by stripping/ignoring all unknown rules. This is not a good solution for eslint itself but for an editor plugin, it might ensure future compatibility (and prevent crashes on unknown plugins).

That being said, there are currently only a handful of eslint plugins. You might want to decide to include a few of them in linter-eslint (I would certainly welcome it).

from linter-eslint.

The problem is that the config (.eslintrc) loading and merging is delegated to the eslint API to ensure a consistent behaviour with the command line. So at the moment I see the following options:

• add all existing plugins like you propose (easy but not future-proof)
• ask the eslint team for a change in their API to avoid error when plugin is not found (difficult to obtain)
• use something like https://www.npmjs.org/package/app-module-path to add additional module directories to the node module path (dangerous, can be a bad behaviour for an atom plugin)
• use the previous solution but in an external process to avoid polluting atom

from linter-eslint.

Sounds like the best option for now would be option 2, i.e. adding a silent error option to eslint.

From a quick code search, it looks like this else branch is all that needs to change for missing rule errors to be silent.

Wait—you wrote that "loading and merging is delegated to the eslint API". But that just means that you retrieve the config from eslint, to then pass that config object to linter.verify. I added a breakpoint to this line, got the config and was able to modify it before passing it on to linter.verify:

# Line 43
config = engine.getConfigForFile(origPath)
config.plugins = _.omit(config.rules, (val, key) -> _.contains(key, '/'))

result = linter.verify @editor.getText(), config
# ...

If I'm not mistaken, this is all you need to remove plugin-based rules.

from linter-eslint.

You are right. I think this is the best option at the moment. Would you mind submitting a PR ?

from linter-eslint.

Sure thing: #18

from linter-eslint.

Should not break anymore but real plugin support would be cool.

from linter-eslint.