Git Product home page Git Product logo

Comments (5)

Undistraction avatar Undistraction commented on July 22, 2024

I think the way to approach this is to have a unified API offered by JSObjection allowing registration and bindings which is then used by modules as a convenient way of grouping these decisions/actions in one place. In fact I think it would greatly simplify the API if the idea of registering and the idea of bindings were unified as they are essentially the same thing to someone using the API. Anything that can be done in a module should be able to be achieved outside the module.

from objection.

jdewind avatar jdewind commented on July 22, 2024

I don't think I'll move those kind of mechanisms into JSObjection since I set it up to act as class registry for Injectors to use for creating dependencies.

The responsibilities are as follows:

  • JSObjection is a global class registry
  • JSObjectionInjectors provide objects using the global class registry but do not manipulate global state
  • JSObjectionModule defines new bindings that a Injector uses when the class registry is not enough
  • JSObjectionEntry defines how an object is brought into existence

Putting those responsibilities in one place violates single responsibility principle. The perceived convenience is a red herring to me.

from objection.

Undistraction avatar Undistraction commented on July 22, 2024

True. And I'm probably just being myopic, but I'm not suggesting you merge any of those classes or violate the SRP. I suppose I'm saying two things:

  1. I shouldn't have to create a module in order to ask for a Protocol dependency to be satisfied with a class instance. A module is great for grouping a set of related decisions together, but it is overkill for asking for a single dependency to be satisfied and adds unnecessary complexity in these cases.
  2. I would like a unified API that offers the following available to me from inside a module or not (These are taken from an adapter I am using in front of Objection at the moment):

-(void)whenAskedForClassSupplyClass:(Class)clazz;
-(void)whenAskedForClass:(Class)clazz supplyInstance:(id)instance;
-(void)whenAskedForProtocol:(Protocol *)protocol supplyInstance:(id)instance;
-(void)whenAskedForProtocol:(Protocol *)protocol supplyClass:(Class)clazz;
-(void)mapSingleton:(Class)clazz;
-(void)whenAskedForProtocol:(id)protocol supplySingletonOfClass:(Class)clazz;

from objection.

jdewind avatar jdewind commented on July 22, 2024

It appears that you are asking for another registry mechanism for protocols. The reason I've avoided that is that protocols are used sparingly in Objective-C outside of the delegate pattern.

from objection.

jdewind avatar jdewind commented on July 22, 2024

For reference,

JIT bindings for Guice does this. http://code.google.com/p/google-guice/wiki/JustInTimeBindings.

from objection.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.