Git Product home page Git Product logo

Comments (2)

timcallow avatar timcallow commented on September 23, 2024 1

Ok thanks for clarifying that and see PR #16.

For consistency I would prefer to go with non-imperative docstrings if you agree.

from atomec.

DanielKotik avatar DanielKotik commented on September 23, 2024

On this imperative mood thing with regards to properties there is an ongoing discussion: PyCQA/pydocstyle#301

If you follow strictly the rules defined in https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_numpy.html then there is no clash. Change (please note capitalised The ...)

-"""dict of floats: the xc energy, containing keys `x`, `c` and `xc`
-for exchange, correlation and exchange + correlation respectively"""
+""":obj:`dict` of :obj:`float`: The xc energy.
+
+Contains keys `x`, `c` and `xc` for exchange, correlation and
+exchange + correlation respectively.
+"""

But Numpy itself uses imperative mood style, e.g. here 🤷‍♂️

grafik

Important is consistency.

from atomec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.