Git Product home page Git Product logo

Comments (5)

damieng avatar damieng commented on August 25, 2024

Right beneath that section is another section called Available packages that links to complete GitHub repos for Atom packages for Java (Eclipse JDT language server) and C# (Omnisharp-node language server)

from atom-languageclient.

 avatar commented on August 25, 2024

Yes I am aware, however that was not the point of the ticket.

The point was that IMHO real world examples that are usually more complex aren't an ideal replacement for a most minimal but ocmplete working example, which I think should be prepared and added as a link as well. It's just a better place to start than a (good) code example which is nevertheless not fully described in where it needs to go and then just sending off the newcomers to real world packages that go beyond illustrating the most basic setup.

It's just a minor nitpick really. Feel free to ignore it too, I just felt like it was a point worth improving when I read the README.md for the first time.

from atom-languageclient.

damieng avatar damieng commented on August 25, 2024

Sorry I didn't make it clear - the Omnisharp C# one at https://github.com/atom/languageserver-csharp is just the code from the README with the necessary support files to make it an Atom package - i.e. what I thought you were asking for. There is zero other code.

I agree that many language servers are going to require a lot more additional plumbing (the Java one for example has downloads and platform-specific args) but the Omnisharp one is as minimal as can be.

from atom-languageclient.

 avatar commented on August 25, 2024

Ah. Maybe add a note to the README.md then? Since the Java LSP is linked first and obviously has more stuff going on, it's not super obvious that there is also a minimal base example available in one of the later links.

Also, I think it might be helpful for visibility to actually link just this one right below the snippet as a "and here you have this snippet packaged up nicely to run it immediately" kind of thing, and not just in the further down section with the more expanded collection of related packages and other examples.

Edit: just for clarification, what happened to me is that I ended up looking at the Java LSP instead when I read the README for the first time. It wasn't bad to start with, but I would have preferred a minimal working example instead if I had known that was linked in the README.md. Hence this ticket suggestion to improve the visibility of a minimal base packaged up thing

from atom-languageclient.

damieng avatar damieng commented on August 25, 2024

I'll reorder them and clarify it in the readme, thanks.

from atom-languageclient.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.