Should allow for login if the token from keychain is not found about apm HOT 5 CLOSED

So I dug into what it would take to install our atom npm packages into atom_modules and our system npm packages into node_modules.

• We would need to modify npm to allow installing to a custom global directory.
• We would then need to modify apm to install globally (to atom_modules) when installing packages and dependencies used within atom and locally when installing dependencies that should be used when using grunt/apm. As part of this step we would most likely need to modify atom's package.json such that devDependencies and dependencies only included the modules that would be used by the system npm.
• We would need to modify atom-shell on windows and on osx to set NODE_PATH to atom_modules before node is loaded within atom-shell.

However after outlining those steps, I wonder if we could do something clever where we create shims for node and npm after doing the initial bootstrap.

node

#!/bin/bash
ATOM_BIN=`dirname "${BASH_SOURCE[0]}"`/../atom-shell/Atom.app/Contents/MacOS/Atom
ATOM_SHELL_INTERNAL_RUN_AS_NODE=1 $ATOM_BIN "$@"

npm

#!/bin/sh
NPM_BIN=`dirname "${BASH_SOURCE[0]}"`/../node_modules/atom-package-manager/node_modules/.bin/npm
$NPM_BIN

And then we tell people to export PATH=./bin/:$PATH so that if they execute node (or anything that uses node) from atom's root that it will use our node instead of the system node? I'd prefer this approach, thoughts?

from apm.

What about putting apm and grunt dependencies in their old own folders with their own node_modules folder in there?

So build/node_modules would be where all the grunt dependencies go and apm/node_modules would be where all the apm dependencies go. We could add grunt.sh and apm.sh at the root of the atom repo so the commands could still be run from there and they would just shim to the build/node_modules/.bin/grunt and apm/node_modules/atom-package-manager/.bin/apm.

That leaves the root node_modules for just package dependencies and module dependencies that actually need to ship with atom.

We could move the grunt dependencies perhaps into buid/package.json to segregate.

Just an initial idea, still not 100% clear on if it would work but could be worth a spike.

from apm.

Would any of this be necessary if we this worked?

from apm.

It's more about fixing this atom/atom#1067, I guess I should have put my comment there.

from apm.

apm now has a login command, closing this out.

from apm.