Git Product home page Git Product logo

Comments (23)

Stanzilla avatar Stanzilla commented on May 27, 2024 6

@jerone this is back in Atom 1.16.beta0

ReferenceError: positionMenu is not defined

from tool-bar.

forestgagnon avatar forestgagnon commented on May 27, 2024 2

@zertosh the update just broke tool-bar in my Atom 1.15.0

TypeError: Cannot read property 'element' of undefined
    at Object.unfixToolBarHeight (/Users/fgagno/.atom/packages/flex-tool-bar/lib/flex-tool-bar.coffee:171:21)
    at Object.reloadToolbar (/Users/fgagno/.atom/packages/flex-tool-bar/lib/flex-tool-bar.coffee:163:8)
    at Object.consumeToolBar (/Users/fgagno/.atom/packages/flex-tool-bar/lib/flex-tool-bar.coffee:151:6)
    at Provider.module.exports.Provider.provide (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/service-hub/lib/provider.js:29:52)
    at ServiceHub.module.exports.ServiceHub.provide (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/service-hub/lib/service-hub.js:30:20)
    at Package.module.exports.Package.activateServices (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:396:71)
    at Package.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:221:16)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:190:32
    at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:96:15)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:183:26
    at Package.module.exports.Package.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:180:34)
    at PackageManager.module.exports.PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:550:34)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:531:29
    at Config.module.exports.Config.transactAsync (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:337:18)
    at PackageManager.module.exports.PackageManager.activatePackages (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:526:19)
    at PackageManager.module.exports.PackageManager.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:508:46)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:812:28

from tool-bar.

cakecatz avatar cakecatz commented on May 27, 2024 2

@forestgagnon I merged @zertosh 's PR and published [email protected] 😎

from tool-bar.

zertosh avatar zertosh commented on May 27, 2024 1

@forestgagnon looking into it

from tool-bar.

suda avatar suda commented on May 27, 2024

Hi @urzds this seems to be connected to Nuclide. Could you try to upgrade it to 0.111.0 and see if it helps?

from tool-bar.

avatar commented on May 27, 2024

@suda: Hello! Yes, by now the error message does not appear anymore.

from tool-bar.

suda avatar suda commented on May 27, 2024

Great! Thanks for checking this :)

from tool-bar.

stryju avatar stryju commented on May 27, 2024

0.111.0 of nuclide didn't help for latest update 0.1.11

Atom Version: 1.4.0
System: Mac OS X 10.11.2
Thrown From: tool-bar package, v0.1.11

Stack Trace

Failed to activate the tool-bar package

At Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node.

Error: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node.
  at Error (native)
  at ToolBarView.module.exports.ToolBarView.addItem (/Users/stryju/.atom/packages/tool-bar/lib/tool-bar-view.coffee:21:15)
  at ToolBarManager.module.exports.ToolBarManager.addButton (/Users/stryju/.atom/packages/tool-bar/lib/tool-bar-manager.coffee:10:14)
  at Object.consumeToolBar (/opt/facebook/nuclide/0.111.20207720-1/nuclide/pkg/nuclide/debugger/atom/lib/main.js:215:13)
  at Provider.module.exports.Provider.provide (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/service-hub/lib/provider.js:30:52)
  at ServiceHub.module.exports.ServiceHub.provide (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/service-hub/lib/service-hub.js:30:20)
  at Package.module.exports.Package.activateServices (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:351:71)
  at Package.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:186:16)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:156:32
  at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:92:15)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:149:26
  at Package.module.exports.Package.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:146:34)
  at PackageManager.module.exports.PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:524:21)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:336:19
  at /Applications/Atom.app/Contents/Resources/app.asar/src/config.js:623:20
  at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
  at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:125:28)
  at Config.module.exports.Config.emitChangeEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:808:29)
  at Config.module.exports.Config.setRawValue (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:600:19)
  at Config.module.exports.Config.set (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:227:14)
  at Config.module.exports.Config.removeAtKeyPath (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:377:12)
  at Package.module.exports.Package.enable (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:77:26)
  at PackageManager.module.exports.PackageManager.enablePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:165:14)
  at HTMLButtonElement.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/settings-view/lib/package-card.js:314:27)
  at HTMLButtonElement.jQuery.event.dispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-space-pen-views/node_modules/space-pen/node_modules/jquery/dist/jquery.js:4435:9)
  at HTMLButtonElement.elemData.handle (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-space-pen-views/node_modules/space-pen/node_modules/jquery/dist/jquery.js:4121:28)

Commands

     -1:12.5.0 settings-view:check-for-package-updates (atom-workspace.workspace.scrollbars-visible-always.theme-material-syntax.theme-atom-material-ui)

Config

{
  "core": {
    "destroyEmptyPanes": false,
    "disabledPackages": [
      "deprecation-cop",
      "fuzzy-finder",
      "metrics",
      "styleguide",
      "timecop",
      "pane-manager",
      "tree-view"
    ],
    "themes": [
      "atom-material-ui",
      "material-syntax"
    ]
  },
  "tool-bar": {
    "iconSize": "16px",
    "position": "Right"
  }
}

Installed Packages

# User
atom-material-ui, v0.8.0
docblockr, v0.7.3
emmet, v2.4.0
file-icons, v1.6.14
haskell-grammar, v0.4.0
highlight-selected, v0.11.1
language-babel, v2.11.3
language-ini, v1.14.0
language-ocaml, v1.1.2
language-svg, v0.9.0
language-thrift, v1.0.2
material-syntax, v0.5.0
minimap, v4.19.0
nuclide, v0.111.20207720-1
tool-bar, v0.1.11

# Dev
No dev packages

from tool-bar.

jerone avatar jerone commented on May 27, 2024

Does Nuclide provide two toolbar or alters it standard ToolBar buttons?

from tool-bar.

avatar commented on May 27, 2024

This is what the tool-bar looks like with Nuclide installed:
nuclide-tool-bar

from tool-bar.

zertosh avatar zertosh commented on May 27, 2024

@jerone I work on nuclide. On both our internal and external releases (for those facebookers reading this) only use one toolbar. However, some features, like the diff-view manipulate the toolbar element to show some state. The diff-view changes color and shows a badge with the number of changed files. Usually we just mount a React a component on the toolbar element that we cleanup on deactivate.

I have noticed that since the toolbar doesn't provide a mechanism to notify consumers when the tool-bar itself is deactivated, we end up in bad state where things like the diff-view still think that the toolbar element is in the DOM.

How do you feel about the ToolBarManager exposing the ToolBarView's subscriptions object (in a sanctioned way), so that consumers can do other cleanup if the tool-bar package is disabled? This would really improve the experience of doing a graceful toolbar upgrade for example.

from tool-bar.

jerone avatar jerone commented on May 27, 2024

You mean that when the Tool Bar package is disabled, the reference to the button added by your package is still alive?
What about we empty all button references, so when doing changes to your buttons you have to check if your button isn't null?

We're always open for an PR.

from tool-bar.

zertosh avatar zertosh commented on May 27, 2024

#101 fixes this issue and provides a way for consumers to be notified when the Tool Bar package is destroyed.

from tool-bar.

jamesgpearce avatar jamesgpearce commented on May 27, 2024

Saw this upgrading to 0.2.0 but I guess I won't see it again?

from tool-bar.

jerone avatar jerone commented on May 27, 2024

It shouldn't be happening again if you install latest version.

from tool-bar.

newelement avatar newelement commented on May 27, 2024

This has returned as of Atom v1.16

from tool-bar.

danielbayley avatar danielbayley commented on May 27, 2024

this is back in Atom 1.16.beta0

@jerone Me too! 😢

ReferenceError: positionMenu is not defined
  at ToolBarView.updateMenu (/Users/Dan/Library/Application Support/Atom/packages/tool-bar/lib/tool-bar-view.js:166:39)
  at ToolBarView.updatePosition (/Users/Dan/Library/Application Support/Atom/packages/tool-bar/lib/tool-bar-view.js:155:10)
  at ToolBarView.show (/Users/Dan/Library/Application Support/Atom/packages/tool-bar/lib/tool-bar-view.js:202:10)
  at new ToolBarView (/Users/Dan/Library/Application Support/Atom/packages/tool-bar/lib/tool-bar-view.js:58:12)
  at Object.activate (/Users/Dan/Library/Application Support/Atom/packages/tool-bar/lib/tool-bar.js:25:13)
  at Package.module.exports.Package.activateNow (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/package.js:218:19)
  at /Applications/Atom Beta.app/Contents/Resources/app.asar/src/package.js:190:32
  at Package.module.exports.Package.measure (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/package.js:96:15)
  at /Applications/Atom Beta.app/Contents/Resources/app.asar/src/package.js:183:26
  at Package.module.exports.Package.activate (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/package.js:180:34)
  at PackageManager.module.exports.PackageManager.activatePackage (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/package-manager.js:550:34)
  at /Applications/Atom Beta.app/Contents/Resources/app.asar/src/package-manager.js:531:29
  at Config.module.exports.Config.transactAsync (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/config.js:337:18)
  at PackageManager.module.exports.PackageManager.activatePackages (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/package-manager.js:526:19)
  at PackageManager.module.exports.PackageManager.activate (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/package-manager.js:508:46)
  at /Applications/Atom Beta.app/Contents/Resources/app.asar/src/atom-environment.js:826:28

from tool-bar.

zertosh avatar zertosh commented on May 27, 2024

#161 fixes the issue in Atom 1.6.0. That's in master already, but @jerone needs to publish a new version.

from tool-bar.

zertosh avatar zertosh commented on May 27, 2024

I just published [email protected] that fixes the Atom 1.16.0 issue

from tool-bar.

zertosh avatar zertosh commented on May 27, 2024

@forestgagnon here's the fix cakecatz/flex-toolbar#98

from tool-bar.

MggMuggins avatar MggMuggins commented on May 27, 2024

How do I update to that revision? Will you be pushing a revision that makes sure this doesn't happen in the release versions?

from tool-bar.

MggMuggins avatar MggMuggins commented on May 27, 2024

Thanks, works like a charm now!

from tool-bar.

forestgagnon avatar forestgagnon commented on May 27, 2024

Awesome thanks!

from tool-bar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.