Git Product home page Git Product logo

Comments (11)

svinkle avatar svinkle commented on May 6, 2024

As mentioned over in a11yproject/a11yproject.com#513 (comment), here are a few instructions/audible cues that would be beneficial for people who rely on screen readers:

  • How to pick up and put down items
  • Which order items are now in after dropping
  • How many items there are in total
  • Semantic meaning for each item (currently announced as, "link")

I just did a quick pass to check things over with Chrome + VoiceOver on maxOS. This needs to be tested with other browser/screen reader combinations as well.

Time permitting, I'd like to jump in and conduct more testing and dive into the code to see where these types of announcements and semantics could be added.

All that said, the keyboard support is really fantastic! 👍

from react-beautiful-dnd.

alexreardon avatar alexreardon commented on May 6, 2024

Thanks for looking into this @svinkle !!

from react-beautiful-dnd.

alexreardon avatar alexreardon commented on May 6, 2024

Super relevant: https://medium.com/salesforce-ux/4-major-patterns-for-accessible-drag-and-drop-1d43f64ebf09

from react-beautiful-dnd.

alexreardon avatar alexreardon commented on May 6, 2024

Thanks @seancurtis for the link!

from react-beautiful-dnd.

alexreardon avatar alexreardon commented on May 6, 2024

Another good article: https://www.smashingmagazine.com/2018/01/dragon-drop-accessible-list-reordering

from react-beautiful-dnd.

alexreardon avatar alexreardon commented on May 6, 2024

I am looking into api options for this. Currently:

onDragStart(start: DragStart, {announce: (message) => void})

where you call announce with your message. If you do not call it then we use a default message

or

onDragStart(start: DragStart): string

We use the string you return from the handler as the message. If not is returned then we use a default. This is clean, but it might be a bit confusing to return a string from an event handler

from react-beautiful-dnd.

alexreardon avatar alexreardon commented on May 6, 2024

@svinkle this will be shipping in v5 👍

from react-beautiful-dnd.

svinkle avatar svinkle commented on May 6, 2024

@alexreardon Awesome! Any method available where I could test the work being done so far?

from react-beautiful-dnd.

alexreardon avatar alexreardon commented on May 6, 2024

from react-beautiful-dnd.

alexreardon avatar alexreardon commented on May 6, 2024

from react-beautiful-dnd.

alexreardon avatar alexreardon commented on May 6, 2024

This has been completed as a part of #321

It feels (and sounds) great!

from react-beautiful-dnd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.