add update script about xpadneo HOT 7 CLOSED

Dont know where to say thanks so Im doing it here. After using only the controller wired (I knew today xpadneo was to make it work wireless) I uninstalled 0.6, installed 0.7.2 and it worked wirelessly at the first try, and it did the rumble thing! thanks!

from xpadneo.

Hi there, at the moment the best practice is the following:

1. uninstall the outdated driver by running its ./uninstall.sh script
2. update the git clone by running git pull
3. install the newly version by running ./install.sh

It is in fact important to uninstall the old version using the outdated uninstall.sh script before you update, otherwise the old versions will accumulate as /usr/src/hid-xpadneo-$VERSION/.

It is most probably not the best and cleanest solution as it is at the moment.
Which behavior would you expect as a user?

Most probably the uninstall script should install every old instance too,...

Maybe we should

1. add an update.sh script
2. let the uninstall script remove all old versions

from xpadneo.

Hi,

Thanks for the reply. I would agree, the ideal solution would be to create an update.sh script which handles any cleanup and reconfiguration, and the uninstall script should remove all versions/traces.

As a user, I can see people potentially redownloading the new version and running the install.sh again assuming they will get a clean update, or what they will likely do is run the uninstall.sh on the new download, which wouldn't remove the old version.

Maybe you can do something similar to how the scraping tool skyscraper does it:
https://github.com/muldjord/skyscraper/blob/master/update_skyscraper.sh

It looks for contents of the VERSION file in the top level directory, and I guess does a compare of sorts, if it differs it'll either download the new release and update, or it will suggest you have the new version already and close.

Also, just an additional idea, on the install.sh you could run a similar check to see if the driver is already installed and guide the user accordingly to either update or uninstall.

Cheers!

from xpadneo.

would you please give it a try?
the branch is called "update_script".

https://github.com/atar-axis/xpadneo/tree/update_script

from xpadneo.

Btw, in the case that the repo directory is outdated it wont be updated automatically because the update script is executed via sudo and I don't like the idea that git pull is executed as superuser. You will see a hint on how to update it by hand - once it is up-to-date, the rest is done automatically.

from xpadneo.

Wow, thanks! I will give this a go a little later on when I am at home and let you know what happens. How would you like me to test this?

Do you want me to remove my driver completely using the existing uninstall.sh, download the update branch and try to update (I should get a message saying it's the current version).

Or - do you want me to run a "git pull origin update_script" command (non sudo) on my existing directory (which I assume will bring down the branch update_script and merge? I am not experienced with git commands so please correct me if this is wrong). And once complete run update.sh as superuser?

Thanks

from xpadneo.

Anyway, I will merge it to the master branch, it is not a critical update so if it doesn't work 100% as expected it won't be a big problem. In that case we will hear from others very soon I guess ;)

I think it works just fine as it is, I already tested it a bit.

from xpadneo.