form is loaded in $dirty state when used with moment object about angular-eonasdan-datetimepicker HOT 10 CLOSED

Hi.

I admit it can be somehow an undesirable 'feature', but to be honest, I did not encounter this problem before. I have done a fast check and from what I see, even if the date is not set the form gets instantly dirty.

If you need a walkaround... I would simpy add this to your controller.

$timeout(function() {
  $scope.dateForm.$setPristine();
});

It works with a plunker: http://plnkr.co/edit/L1HIMU

But to truly address this problem I would need to first find what causes the dirty state. Especially, if the problem lays in the wrapper or in the library.

At the moment I am not sure if I will have time to patch this (or find the source of an issue). Any PRs are welcome 😄

from angular-eonasdan-datetimepicker.

Problem lays within this line: https://github.com/atais/angular-eonasdan-datetimepicker/blob/master/dist/angular-eonasdan-datetimepicker.js#L29. When setting ngModel's view value, it becomes $dirty

from angular-eonasdan-datetimepicker.

Thanks @shustariov-andrey !

But well... it is a core line of this wrapper.

I can see there is a walkaround, fe. http://stackoverflow.com/questions/28242788/how-to-reset-custom-input-directive-and-its-parent-form-to-pristine but it seems quite dirty to me.

I would appreciate any ideas.

from angular-eonasdan-datetimepicker.

How about

if (ngModel.$viewValue === null) {
   ngModel.$setViewValue(null);
}

?

I mean, undefined value should not make model dirty at the first place

from angular-eonasdan-datetimepicker.

I should start putting comments in that code 😢

the reason i check for !ngModel.$viewValue instead of ngModel.$viewValue === null is that if you pass undefined or false to ng-model it would pass this value to the datetimepicker.

And actually eonasdan-datetimepicker does not like that and it causes console errors. The only value it accept is moment or null (I think Date was good too).

I have actually done the above in previous version 😉

What is more I think that it is not that ngModel.$setViewValue(null); causes $dirty state, but ngModel.$setViewValue(moment(ngModel.$viewValue)); in general ?

And this is basically linking the model to date time picker.

from angular-eonasdan-datetimepicker.

Ok, need to debug it deeper in this case...

from angular-eonasdan-datetimepicker.

ok, here what works fine for me now:

            if (!_.isUndefined(ngModel.$viewValue) && !moment.isMoment(ngModel.$viewValue)) {
                ngModel.$setViewValue(moment(ngModel.$viewValue));
            }
            if (moment.isMoment(ngModel.$viewValue)) {
                dpElement.data('DateTimePicker').date(ngModel.$viewValue);
            }

from angular-eonasdan-datetimepicker.

@shustariov-andrey would you fork the repo and make a PR?

I will test it and we can make a new version 👍 ?

from angular-eonasdan-datetimepicker.

ok, will do

from angular-eonasdan-datetimepicker.

Great! #21 fixed it.

Enjoy 0.3.9 available on bower & npm 😄 !

from angular-eonasdan-datetimepicker.