Not able to configure my own ChannelPipeline about async-http-client HOT 9 CLOSED

Mark the issue as an enhancements. This could be done using the NettyAsyncHttpProviderConfig allowing the use of customized Pipeline

from async-http-client.

This has been fixed and available now by #205

from async-http-client.

Backport to 1.7.x?

from async-http-client.

Not necessary IMO.

from async-http-client.

I would re-open this issue if I could.

The current implementation in 1.9.33 has taken away the ability to customize your own Channel Pipeline. The code in question has been moved into the method:

configureBootstraps(NettyRequestSender requestSender, AtomicBoolean closed) 

of class com.ning.http.client.providers.netty.channel.ChannelManager

where many of the variables you would want to access are private.

from async-http-client.

With all due respect to Jean-François, I think this move was a wrong one. Allowing for extensibility this way is no less than making it easier for people for fork without ever contributing back. That's not how open-source is supposed to work!

If you need to customize the pipeline, there's the channel initializers in the Netty config. Otherwise, state your use case and let's discuss about it so we can bring a solution that can benefit the whole project, not just you alone.

from async-http-client.

Your comment pointed me in the right direction. I had a similar use case to the original submitter. I wanted to not automatically decompress gzip files. The below, written in Groovy, worked for me.

Perhaps the real issue is that the documentation is scarce. I was attempting to use the approach talked about in this ticket, which no longer works.

myNettyProviderConfig.setHttpAdditionalPipelineInitializer(new NettyPipelineInflaterRemover())

public static class NettyPipelineInflaterRemover extends com.ning.http.client.providers.netty.NettyAsyncHttpProviderConfig.AdditionalPipelineInitializer {
    void    initPipeline(org.jboss.netty.channel.ChannelPipeline pipeline) {
        pipeline.remove(com.ning.http.client.providers.netty.channel.ChannelManager.INFLATER_HANDLER)
    }
}

from async-http-client.

The new way to do it was implemented here: #717

from async-http-client.

Perhaps the real issue is that the documentation is scarce.

It's not like I'm getting any help here, nor that I make a living with this project... :(

from async-http-client.