Git Product home page Git Product logo

Comments (7)

magicmatatjahu avatar magicmatatjahu commented on June 2, 2024 1

@ayasahmad63 @NuclearCactus Hi! Both of you are making the same mistake in your PRs. Adapter variable in the addAdapter function is needed: the single item/object in the adapters array has exactly Adapter field, so you should propagate the first argument to new item in the adapters array. How to do it I won't say, that's what learning is all about :)

I don't want to decide which PR will be merged first, but @ayasahmad63 himself has priority because his PR was first.

from glee.

magicmatatjahu avatar magicmatatjahu commented on June 2, 2024 1

As I see @ayasahmad63 closed his PR, so @NuclearCactus please follow with my suggestion in the #119 PR :)

from glee.

NuclearCactus avatar NuclearCactus commented on June 2, 2024

Please assign this issue to me, I'll help you with it right away!

from glee.

ayasahmad7655 avatar ayasahmad7655 commented on June 2, 2024

pls assign to me

from glee.

derberg avatar derberg commented on June 2, 2024

Not sure where are we here 😄 what should we review?

from glee.

NuclearCactus avatar NuclearCactus commented on June 2, 2024

As I see @ayasahmad63 closed his PR, so @NuclearCactus please follow with my suggestion in the #119 PR :)

Okay, I'll try my best to solve this issue!

from glee.

asyncapi-bot avatar asyncapi-bot commented on June 2, 2024

🎉 This issue has been resolved in version 0.4.48 🎉

The release is available on:

Your semantic-release bot 📦🚀

from glee.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.