Git Product home page Git Product logo

Comments (10)

jonaslagoni avatar jonaslagoni commented on June 18, 2024 1

For sure, feel free to bring it up 👍

from bundler.

jonaslagoni avatar jonaslagoni commented on June 18, 2024

cc codeowners @Souvikns @derberg

Would be really cool to have this library work out the gate when we release v3, are any of you interested in scheduling a public call specifically to discuss how to enable this?

If you have any questions about how it can be achieved or v3-specific stuff I can help answer those in the meeting to enable you to progress with this 🙂

Let me know if it has any interest.

from bundler.

Souvikns avatar Souvikns commented on June 18, 2024

Would be really cool to have this library work out the gate when we release v3, are any of you interested in scheduling a public call specifically to discuss how to enable this?

Sure @jonaslagoni let me read up on spec3 and see what needs to be changed in bundler to support it, Maybe we can discuss about this at the next spec 3.0 meeting

from bundler.

Souvikns avatar Souvikns commented on June 18, 2024

I was trying to figure out what needs to be changed in the bundler for it to support spec v3.

Currently

  • bundler parses the channels and looks for $ref's in the message object
  • resolves the $ref to either the message or to the component object and updates the $ref accordingly.

With V3

The only difference in our case is that now we can have multiple message objects so the only thing that changes is how we look for the message components. operations can have messages as well so we need to parse that as well, but we only resolve it if the $ref is outside the current spec i.e. we are referencing a message from a different file.

cc @jonaslagoni

from bundler.

jonaslagoni avatar jonaslagoni commented on June 18, 2024

Not sure how much this change affect your logic: https://v3.asyncapi.com/blog/release-notes-3.0.0#unified-referencing-behaviors

from bundler.

Souvikns avatar Souvikns commented on June 18, 2024

Don't think this affects bundler currently, as it only looks for message references and nothing else.

path: '$.channels.*.*.message',

from bundler.

Souvikns avatar Souvikns commented on June 18, 2024

@jonaslagoni working on a PR, will create a separate logic for spec 3.0 and add a check for the spec inputted in bundler to either use the current logic or the new one.

from bundler.

asyncapi-bot avatar asyncapi-bot commented on June 18, 2024

🎉 This issue has been resolved in version 0.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

from bundler.

mfroberg avatar mfroberg commented on June 18, 2024

I am trying to use the bundle command of the Async API CLI tool v1.4.11. It gives be the error "One of the files you tried to bundle is AsyncAPI v3 format, the bundle command does not support it yet" and refers to this issue #133.

Since this issue is closed, I am confused. Maybe I am in the wrong place looking for v3 support for the bundle command? Or missing something obvious? :)

from bundler.

Souvikns avatar Souvikns commented on June 18, 2024

In case you got redirected here looking for v3 support for the bundle CLI command, please check the following issue: asyncapi/cli#1137

from bundler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.