Git Product home page Git Product logo

Comments (6)

andscoop avatar andscoop commented on May 30, 2024

@tedmiston What OS? If a user has deleted their ~/.bash_profile they have likely done so for a reason. I'm not opposed, just one thing to consider

from astro-cli.

tedmiston avatar tedmiston commented on May 30, 2024

He was on macOS (not sure which version). In his case the file was renamed, potentially out of error or mistake because he had no other commands in it.

Do you know if an empty ~/.bash_profile is automatically created for a new user account on macOS / Linux? I'm not sure.

If it's automatically created and the user doesn't have one, perhaps we could output an error message something like:

Please create a .bash_profile so that we can add the CLI binary to your $PATH.

    $ touch ~/.bash_profile

What do you think?

from astro-cli.

cwurtz avatar cwurtz commented on May 30, 2024

I'm 90% sure either .bash_profile or .bashrc has to be created on OS X, but could be misremembering.

In my opinion, if the file doesn't exist we should just output a message like:

Couldn't automatically add astro-cli to your path.  Add the following to your profile:
export PATH="$PATH:/path/to/astro"

That being said, aren't we already putting astro-cli in /usr/local/bin or something?

from astro-cli.

tedmiston avatar tedmiston commented on May 30, 2024

Yeah, personally I prefer being given the command to add to my profile vs having a script modify my profile for me. Partly because I put most commands in .bashrc instead of .bash_profile myself.

from astro-cli.

schnie avatar schnie commented on May 30, 2024

Yea, astro should be installed into standard path that should already exist in $PATH. Where in our installation does it append this?

from astro-cli.

ryw avatar ryw commented on May 30, 2024

i'd say we should detect presence of ~/.bash_profile and tell them they need create it before proceeding, could link to a guide

from astro-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.