Duplicated data types with GNU Demangler about ghidra-cpp-class-analyzer HOT 6 CLOSED

Unfortunately this is a Ghidra problem. I'm actually logging every single time Ghidra returns the wrong class from the method it uses to get the type for a thiscall function. You can open an issue in the Ghidra repo and hope they finally do something about it.

I recommend leaving the demangler analyzer on. I'll see if I can hack up a script to help deal with this but it will end up being very slow because of how the datatype manager handles type replacement.

from ghidra-cpp-class-analyzer.

Thanks! A script would be helpful.

I'm happy to file a bug on Ghidra as well, but it's not clear to me what's going wrong and where. I assumed the demangler analyzer created its own types (in the Demanagler folder in the data type manager), and is using those with the parameters of functions that it similarly created.

Suppose you have two classes namespaceA::Object and namespaceB::Object. If there is no demangler folder, VariableUtilities.findOrCreateClassStruct will return /namespaceA/Object for both of them in their __thiscall functions because that is the first Object it will find.

from ghidra-cpp-class-analyzer.

Hmm. Would DataTypeManager::replaceDataType work properly as a means to deduplicate? Wondering if it is affected by this bug.

https://ghidra.re/ghidra_docs/api/ghidra/program/model/data/DataTypeManager.html#replaceDataType(ghidra.program.model.data.DataType,ghidra.program.model.data.DataType,boolean)

It would work in your case where the datatype being replaced is trash and is the empty placeholder created by the demangler. This is what I would use in a script to fix your situation. However there is currently nothing that can be done about the case with two different valid class structures.

from ghidra-cpp-class-analyzer.

Got something working (for the placeholder case). It only works if the replacement type has the same name, though this limitation is simply because it makes my workflow easier (I can use a simple dropdown when prompting for the replacement type).

Posting for others.
https://gist.github.com/kevinhartman/a4dce3beadfe08dc7fd3fca61fb40567

from ghidra-cpp-class-analyzer.

Thanks! A script would be helpful.

I'm happy to file a bug on Ghidra as well, but it's not clear to me what's going wrong and where. I assumed the demangler analyzer created its own types (in the Demanagler folder in the data type manager), and is using those with the parameters of functions that it similarly created.

from ghidra-cpp-class-analyzer.

Hmm. Would DataTypeManager::replaceDataType work properly as a means to deduplicate? Wondering if it is affected by this bug.

https://ghidra.re/ghidra_docs/api/ghidra/program/model/data/DataTypeManager.html#replaceDataType(ghidra.program.model.data.DataType,ghidra.program.model.data.DataType,boolean)

from ghidra-cpp-class-analyzer.