Git Product home page Git Product logo

Comments (3)

papandreou avatar papandreou commented on September 25, 2024

I can reproduce this, assuming that your setup includes both buildDevelopment and buildProduction. It is indeed caused by buildDevelopment's pretty-printing of the HTML and buildProduction being very careful with removing leading and trailing whitespace during minification.

The latter has been annoying me for a while as it also limits the ability to minify Knockout.js templates before inlining them in JavaScript code.

The thing is that sometimes the whitespace is significant, like in <pre> and when white-space: pre is applied.

When I get the time I'll take a look at what other HTML minifiers are doing and reimplement that.

from assetgraph-builder.

Munter avatar Munter commented on September 25, 2024

I can reproduce this, assuming that your setup includes both buildDevelopment and buildProduction.

This is exactly the case. I would skip buildDevelopment if I could. But since buildProduction doesn't follow INCLUDE relations, I can't. I noted this in issue #19

from assetgraph-builder.

papandreou avatar papandreou commented on September 25, 2024

Distinguishing between significant and insignificant whitespace is surprisingly hard, so in assetgraph 1.0.13 I had to relax the whitespace compression rules a bit, so I disabled minification of Html in buildDevelopment in assetgraph-builder 1.0.15. I still hope to find a better solution later so those extra bytes can be squeezed out.

When you have the time, please check that the sum of these changes don't break your app.

from assetgraph-builder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.