Make buildProduction independent og buildDevelopment about assetgraph-builder HOT 4 CLOSED

It's not quite as easy as that, but we could add a buildProduction switch that did buildDevelopment's flattening of the JavaScript includes before proceeding. I don't understand see how the use case you're describing could work, though.

JavaScriptOneInclude and JavaScriptCommonJsRequire won't work if your development version hasn't been through something like buildDevelopment. (Of course, require.js will work fine).

Also, the i18n features rely on the 'bootstrapper' script in development, so you'll need buildDevelopment eventually.

from assetgraph-builder.

I'm just trying to sell buildProduction to users as an easy way to get started. If it then behaves as they wouldn't expect it's not an easy sell :)

I thought that the only reason why INCLUDE wouldn't be populated in buildDevelopment is that it is specificly filtered out in https://github.com/One-com/assetgraph-builder/blob/master/bin/buildProduction#L165

If JavaScriptInclude was populated, wouldn't buildProduction be able to correctly bundle relations? I am thinking that even if you did a previous buildDevelopment and ran buildProductionon that output, https://github.com/One-com/assetgraph-builder/blob/master/bin/buildProduction#L186 would take care out the double reference and still be able to put the INCLUDEd assets in the right order.

I am here assuming non-usage of the i18n features which i am totally on board with not working in a dev environment without a dev build.

from assetgraph-builder.

Ah, I thought you were talking about one of your own use cases.

If JavaScriptInclude was populated, wouldn't buildProduction be able to correctly bundle relations? I am thinking that even if you did a previous buildDevelopment and ran buildProductionon that output

Well, in theory, yes, but I'm still not a fan, because I fail to see the use case for INCLUDE without buildDevelopment. Your project wouldn't work before it had been run through buildProduction, which would be a terrible workflow. And I really hope we're not trying to sell INCLUDE to new users?

https://github.com/One-com/assetgraph-builder/blob/master/bin/buildProduction#L186 would take care out the double reference and still be able to put the INCLUDEd assets in the right order.

No, mergeIdenticalAssets just makes sure that assets with the same MD5 become the same node in the graph, which they would already be because the INCLUDE and the <script src="..."> would be pointing at the same url. We would need additional transforms to weed out the duplicate <script src="..."> that would be introduced.

All in all I'm not convinced this is worth the extra complexity.

from assetgraph-builder.

I agree that we shouldn't try to market INCLUDE.

I think I might actually have confused myself with this issue. I'll close it and reopen if I remember what my original point was :D

from assetgraph-builder.