Add new WebHost static API to Microsoft.AspNetCore meta-package with opinionated defaults about metapackages HOT 9 CLOSED

Before closing the issue, I will also need to resolve the correct ApplicationName and pass it along to the builder when we wrap the RequestDelegate at https://github.com/aspnet/MetaPackages/blob/dev/src/Microsoft.AspNetCore/WebHost.cs#L38. Otherwise the correct ApplicationName gets overwritten to Microsoft.AspNetCore.

from metapackages.

Adding .UseHandler() following the existing extension methods might be helpful as well skipping .Configure():

IWebHost webHost = new WebHostBuilder().UseKestrel().UseUrls(url).UseHandler(context => context.Response.WriteAsync("Hello, World!")).Build()

from metapackages.

@lutzroeder we don't have a concept of "handlers" in ASP.NET Core (although I course understand the intent) but the bigger issue is a method like that won't compose properly with the rest of the methods on IWebHostBuilder, i.e. you can't call it more than once, you can't call it along with .Configure(), etc. Once you go to the builder API, you have to configure the pipeline the normal way.

from metapackages.

@JunTaoLuo is this done now?

from metapackages.

@JunTaoLuo @davidfowl maybe we should add the debug logger by default too. Originally I think we planned to just merge it into the core logging package and always be on but it could just be enabled by this now. Thoughts?

from metapackages.

I still need to add tests. I only merged the changes to unblock @CesarBS. I think we also found a bug that need to be fixed.

from metapackages.

@JunTaoLuo bugs? 🔥

from metapackages.

@JunTaoLuo please ensure the DebugLogger is added by WebHost.CreateDefaultBuilder too. This needs to happen so that templates don't need to add it and the debug logging continues to work.

from metapackages.

Functional tests added, and follow up issues have been filed.

from metapackages.