Add overloads with IServiceProvider to extension methods? about httpclientfactory HOT 6 CLOSED

PR out for this, let me know what you think #82

from httpclientfactory.

Just as an update to the above, eventually I found IHttpMessageHandlerBuilderFilter which let me configure the handler order exactly as I wanted for the test setup, and now the implementation for setting up GitHub using this library in both our sample application and its tests is very neat. 👍

from httpclientfactory.

Hi sorry for the delay in getting to this, I was out for a few days...

We didn't do this because you're typically in startup code at this point, and you have access to configuration directly. Looking through your code sample, I now see what you're talking about.

Is the conclusion here that you still think we should add something like those extensions?

from httpclientfactory.

I think so, as otherwise if you want to use other services to inform your HTTP registrations, I think you'd have to jump through a few hoops to carry a reference to the service collection yourself so you can turn it into a service provider and reference them at the point of activation.

Maybe it's an advanced scenario and over-complicates things for a first release? I mean, I eventually got to what I needed to do for my use-case, but it took a fair bit of digging around in the APIs to get it plumbed in.

from httpclientfactory.

Ok cool beans, I'll take a crack at this later

from httpclientfactory.

3978e61

from httpclientfactory.