Git Product home page Git Product logo

Comments (5)

 avatar commented on June 21, 2024

Indeed, we should handle exceptions when a task is canceled. write logs for a bug

from httpclientfactory.

glennc avatar glennc commented on June 21, 2024

@reisenberger you would get this now if you use Polly timeout instead of relying on HTTPClient, right? Given the Polly integration.

@NickCraver You've already talked to corefx folks about having HttpClient do this instead of trying to wrap it here?

from httpclientfactory.

reisenberger avatar reisenberger commented on June 21, 2024

you would get this now if you use Polly timeout instead of relying on HTTPClient, right? Given the Polly integration

@glennc @NickCraver Yes. Polly TimeoutPolicy intentionally wraps the cancellation exception in a TimeoutRejectedException if specifically distinguishing its timeout to be the cause of cancellation, so that calling code can disambiguate that from other cancellation, and for UX.

If users choose to use Polly TimeoutPolicy with the new PolicyHttpMessageHandler in HttpClientFactory, they can get this experience.

from httpclientfactory.

mkArtakMSFT avatar mkArtakMSFT commented on June 21, 2024

We're moving this to corefx repo as we don't control how HttpClient behaves.

from httpclientfactory.

mkArtakMSFT avatar mkArtakMSFT commented on June 21, 2024

This issue was moved to dotnet/corefx#29748

from httpclientfactory.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.