Git Product home page Git Product logo

Comments (2)

glennc avatar glennc commented on June 16, 2024 1

Thing we will talk about for this issue:

  1. Can we implement a wildcard in log filtering such that I can set System.Net.Http.HttpClient.*.Polly to Debug and get debug information for all Polly handlers but normal logging for all others. This is based on us having a consistent pattern for all the handlers and should make it easy for everyone to adhere to if they want to provide the same support.
  2. We can add HttpClient to our source names, that seems fine.
  3. Add a suffix onto the outer logger so that it can be filtered separately.
  4. Add the client name to log messages.

from httpclientfactory.

rynowak avatar rynowak commented on June 16, 2024

I'm going to close this issue as fixed. We addressed the feedback from @andrewlock already.

Two things I haven't done yet.

Going to open an issue on Logging for the discussion about wildcards.

I skipped 4. Add the client name to log messages. because I don't remember the use case for it. The client name is now part of the log source names, so you always have it. If we think of an important need for this in the future we can just do it then, it's pretty simple to add.

from httpclientfactory.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.