Comments (2)
Thing we will talk about for this issue:
- Can we implement a wildcard in log filtering such that I can set System.Net.Http.HttpClient.*.Polly to Debug and get debug information for all Polly handlers but normal logging for all others. This is based on us having a consistent pattern for all the handlers and should make it easy for everyone to adhere to if they want to provide the same support.
- We can add HttpClient to our source names, that seems fine.
- Add a suffix onto the outer logger so that it can be filtered separately.
- Add the client name to log messages.
from httpclientfactory.
I'm going to close this issue as fixed. We addressed the feedback from @andrewlock already.
Two things I haven't done yet.
Going to open an issue on Logging for the discussion about wildcards.
I skipped 4. Add the client name to log messages.
because I don't remember the use case for it. The client name is now part of the log source names, so you always have it. If we think of an important need for this in the future we can just do it then, it's pretty simple to add.
from httpclientfactory.
Related Issues (20)
- How Can I Use ClientCertificates in HttpClientFactory.CreateClient HOT 4
- Getting a endless HttpMessageHandler cleanup cycle HOT 29
- Adding a HttpMessageHandlerType that is registred as Transint in IServiceCollection creates strange results HOT 14
- Microsoft.Extensions.Http.Polly.dll is code signed but Polly.Extensions.Http.dll and Polly.dll are not HOT 4
- Don't capture the ExecutionContext in Timers created for expiry HOT 1
- Asp.net restart: Cannot find method HOT 7
- Error: Unable to resolve service for type 'Microsoft.Extensions.Logging.ILogger' while attempting to activate HOT 4
- Test failure: Factory_CleanupCycle_DisposesEligibleHandler HOT 6
- System.InvalidOperationException: Collection was modified; enumeration operation may not execute. HOT 7
- An error occurred while writing to logger(s) HOT 3
- HttpClientFactory Causes High CPU? HOT 33
- Test failure: SuppressScope_False_CreatesNewScope HOT 3
- Running Tests Locally Not Working HOT 4
- In the controller, how do I find the specified type client by name HOT 2
- NullReferenceException in ActiveHandlerTrackingEntry with 2.2.0 preview 3 HOT 8
- Confusing DI behaviour HOT 2
- Remove MessageHandler - Logging Message Handler HOT 5
- Cleanup timer captures logging scopes HOT 3
- Question - HttpMessageHandler access session HOT 2
- Is it possible for HttpClientFactory to target .NET Standard? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from httpclientfactory.