[Bug]: xz not found with new statically linked bsdtar about bazel-lib HOT 5 CLOSED

I agree that's not a desired behavior change. @dzbarsky is the expert on that pre-built bsd tar, I'm not sure if the answer is that xz ought to be statically linked, or if we're meant to call tar with some flags to specify where it can locate an xz binary

from bazel-lib.

My guess is we are not defining HAVE_LIBLZMA when building so we don't take this codepath https://github.com/libarchive/libarchive/blob/1a2fd29f6de7decd097dc4e30629ff96a068f72e/libarchive/archive_read_support_filter_xz.c#L124

Then we end up trying to shell out to system xz instead of using the statically linked lib.

I'll try to send up a patch in the next few days, @alexeagle might make sense to add a test to bazel-lib and/or the bsdtar released repo, wdyt?

from bazel-lib.

@qtica I couldn't repro with your instruction on darwin, but I was able to repro .tar.xz files not working, and defining HAVE_LIBLZMA in compilation fixed that. So hopefully it will fix your issue as well. We saw one more report of .tar.gz not working correctly so I'm hoping to get a repro for that and bundle the fixes, since adding the module to BCR is a bit tedious. Thanks for your patience and stay tuned!

from bazel-lib.

I believe it's fixed by #819

from bazel-lib.

I've confirmed from my side that the latest fix does resolve my issue. Thank you for the quick replies and fix, I just got back from vacation and it's nice to see it's already released in a patch!

I couldn't repro with your instruction on darwin,

I should've specified that the above instructions were on an amd64 linux machine. 🙇 But I'm glad you were able to find another way to reproduce it.

from bazel-lib.