Git Product home page Git Product logo

Comments (3)

asottile avatar asottile commented on August 25, 2024

it should probably just reject these files -- similar to what it does for non-UTF-8 files

from babi.

jkittner avatar jkittner commented on August 25, 2024

it only comes up when trying to render the char, so opening the file with \x00 in it works (second case passes, since the display height is 80 lines) fine, as long as it is not rendered (first case).

@pytest.mark.parametrize('s', (b'\x00', b'\n' * 81 + b'\x00'))
def test_file_contains_zero_bytes(s, run, tmpdir):
    f = tmpdir.join('f')
    f.write_binary(s)
    with run(str(f)) as h, and_exit(h):
        h.press('a')
        h.await_text('*')
        h.press('^S')
        h.await_text('saved!')
        # h.await_text('error! zero byte found:')

It should probably display an error message like for non utf-8 files. So how can we catch this earlier, like when opening instead of when it's rendered? somewhere in babi.file.get_lines, but sio is IO[str] so we can't check b'\x00' in ... and a non byte string of '\x00' should still be allowed...

from babi.

asottile avatar asottile commented on August 25, 2024

here's where the other errors are checked:

babi/babi/file.py

Lines 67 to 75 in 511de75

def _load_file(filename: str) -> tuple[list[str], str, bool, str]:
try:
with open(filename, encoding='UTF-8', newline='') as f:
return get_lines(f)
except UnicodeDecodeError:
raise OpenError(f'error! not utf-8: {filename!r}')
except OSError:
# XXX: not quite correct, but maybe fix another day
raise OpenError(f'error! not a file: {filename!r}')

from babi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.