While adding new social media icons apart from the current ones hover effect is missing about masterportfolio HOT 8 CLOSED

@dineshnadimpalli your PR solves the problem 🐞 . 😄 I don't think it requires another PR.

from masterportfolio.

Oops!😅 misunderstood. Yeah, regarding the PR, as the old one was already merged thought of adding a new one. Will continue on the same from next time. Thanks for the suggestion @th3c0d3br34ker 👍😄

from masterportfolio.

Suggested methods:

1. use of styled components
2. predefining icons and rendering if user has given the data.

from masterportfolio.

Hi, @th3c0d3br34ker can you open another issue and raise a PR if you have any suggested solution for the 2nd point you mentioned. I believe that was not the scope of this issue.

from masterportfolio.

@dineshnadimpalli your PR solves the problem 🐞 . 😄 I don't think it requires another PR.

Cool @th3c0d3br34ker 😁

from masterportfolio.

why fix something which is not broken? 😄

from masterportfolio.

As suggested here #38 (comment) and the discussion that went through after that. Thought, it would be better to improve the code to reduce the inconsistency and raised this issue.

from masterportfolio.

I was talking about raising a new PR @dineshnadimpalli

from masterportfolio.