Memory leak in draw func about react-sine-wave HOT 5 CLOSED

@marcelgruber Thank you for flagging this issue. Can you please share the error as well? It will help me to debug easily.

Also, please include an information about how to regenerate the issue.

from react-sine-wave.

@ashiishme

Here is the error:

The error shows up when I resize the window.

from react-sine-wave.

@marcelgruber I tried to regenerate the issue but it is still working in my case.

Are you trying to implemented the wave on your project? There are no state used on this wave project.

from react-sine-wave.

@ashiishme yes, implementing in my project.

State is used here: https://github.com/ashiishme/react-sine-wave/blob/main/src/app/components/canvas/canvas.tsx

from react-sine-wave.

@marcelgruber The error has to do something with your implementation. You can add a conditional flag and toggle it using clean up function inside useEffect. Something like this:

useEffect(() => {
  let myFlag = true;
  if (myFlag) setState({...}); // you state thing here
  return () => { myFlag = false }; // toggle flag on clean up function so that when unmounted occurs the state doesn't try to change / update that results in the memory leak error.
}, []);

from react-sine-wave.