Comments (5)
zachdaniel
commented on June 1, 2024
1
Alright, I see the issue :) AshPostgres is supposed to know to add the aggregates it depends on the hood, but it wasn't doing that. For other readers, its not expected that it will actually load the dependent values (i.e they may or may not be selected into the response), but it is expected that you can refer to an aggregate from a calculation and have the ash_postgres data layer know what to do.
from ash_postgres.
zachdaniel
commented on June 1, 2024
So is theactive value that depends on that load correct? If the calculated value is correct, but the dependent load is just not there on the return value, that is expected/acceptable behavior. The dependent loads are used to communicate the data that is needed for a given calculation to be successful, but it's not guaranteed that those values will be loaded in the response. Additionally, those dependencies are inferred automatically for expression calculations. Anything you want to be present on the results must be specifically loaded.
If, however, the active field is incorrect or something, that's a different story.
Thanks for the report!
from ash_postgres.
ahey
commented on June 1, 2024
Hi @zachdaniel in this case it's actually throwing an exception:
1) test loading a calculation loads its dependent loads (AshPostgres.CalculationTest)
test/calculation_test.exs:337
** (RuntimeError) Error while building reference: user_is_active
code: |> Api.load!([:active])
stacktrace:
(ash_postgres 1.2.3) lib/expr.ex:576: AshPostgres.Expr.do_dynamic_expr/5
(ash_postgres 1.2.3) lib/expr.ex:391: AshPostgres.Expr.do_dynamic_expr/5
(ash_postgres 1.2.3) lib/calculation.ex:21: anonymous fn/2 in AshPostgres.Calculation.add_calculations/3
(elixir 1.14.2) lib/enum.ex:1658: Enum."-map/2-lists^map/1-0-"/2
(ash_postgres 1.2.3) lib/calculation.ex:19: AshPostgres.Calculation.add_calculations/3
(ash 2.4.25) lib/ash/actions/read.ex:1770: Ash.Actions.Read.run_calculation_query/4
(ash 2.4.25) lib/ash/actions/read.ex:1562: anonymous fn/6 in Ash.Actions.Read.calculation_request/11
(ash 2.4.25) lib/ash/engine/engine.ex:460: anonymous fn/2 in Ash.Engine.run_iteration/1
(ash 2.4.25) lib/ash/engine/engine.ex:615: Ash.Engine.start_pending_tasks/1
(ash 2.4.25) lib/ash/engine/engine.ex:265: Ash.Engine.run_to_completion/1
(ash 2.4.25) lib/ash/engine/engine.ex:194: Ash.Engine.do_run/2
(ash 2.4.25) lib/ash/engine/engine.ex:133: Ash.Engine.run/2
(ash 2.4.25) lib/ash/actions/read.ex:170: Ash.Actions.Read.do_run/3
(ash 2.4.25) lib/ash/actions/read.ex:90: Ash.Actions.Read.run/3
(ash 2.4.25) lib/ash/api/api.ex:810: Ash.Api.load/4
(ash 2.4.25) lib/ash/api/api.ex:784: Ash.Api.load!/4
test/calculation_test.exs:354: (test)from ash_postgres.
zachdaniel
commented on June 1, 2024
Fix released in 1.2.4
from ash_postgres.
ahey
commented on June 1, 2024
Thank you for this @zachdaniel, it's working beautifully.
from ash_postgres.
Related Issues (20)
- Possibly use raw SQL to convert to jsonb (maybe not always) HOT 6
- varchar size info for a column that already exists is missing from migration
- Ash.Error.UnknownError raised when passing a non-UUID value to a query on a UUID field
- Adding a new relationship with multitenancy at the same time generates invalid_foreign_key HOT 1
- Wrong migration order for unique_index when renaming field HOT 2
- Updating the latest Ash causes some queries to break HOT 2
- Generated migrations should be formatted correctly
- Using an AshPostgres resource with a Timescale Hypertable.
- Api.exists? raise an error when multiple result found HOT 2
- Allow layering of Repos HOT 2
- `exists` aggregation ignores `filter` option HOT 3
- First aggregate loses datetime precision HOT 3
- Issue having multiple has_one relationships in a calculation HOT 11
- Calc to agg from calc to agg in separate resource errors HOT 11
- Error building reference HOT 2
- Empty string in relationship converted to nil before save HOT 1
- polymorphic_on_delete option needs refining and potentially moving HOT 1
- polymorphic_on_delete option results in never-ending migration cycle HOT 2
- Relationships are able to cross tenants with attribute strategy HOT 1
- tables with same name and different schemas breaks migration generator logic HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ash_postgres.