Comments (4)
Can I try doing this? Here is my first ever pull request on OSS.
Checked docs -> Code added -> Actual result is expected result.
from pam.
Thanks for your contribution! I've added a couple of reviewers to your pull request so we can see about getting it merged.
A couple of small pointers:
1 - You can link PRs to the issue they solve. This is a good thing to do, because then anybody looking at the issue will see that there is a potential fix waiting in a PR, plus the issue will automatically be closed when the PR is merged. I've manually linked the issue for you.
2 - Supplying a screenshot of the new behaviour as you have done above is always a good idea 👍 . However, it's better to have that on the pull request itself, rather than here on the issue. Your PR might include a before and after, where you show the old output from pam --help
, the output from pam --help
after your change, and the output from pam --version
from pam.
Thanks for the tips! I added the before, after, and actual_output screenshots on the pull request itself.
from pam.
Applied the requested changes from #161 to #174.
from pam.
Related Issues (20)
- plan equality bug
- Cleaning up unused scripts outside the source code directory HOT 4
- Remove/reduce large example data: examples/data/example_data/lsoas
- pytest failure at example notebooks, HOT 1
- Unable to read matsim example berlin plans
- Pip install optional dependencies not working
- pam.activity.simplify_pt_trips is broken
- CI builds are broken
- Docker container entry point should be `python` not `ipython` HOT 4
- Make dev install instructions more prominent
- Improve simple yield speed
- Link to PAM Slack channel (or move user discussions to github)
- Clean up docs versioning in readme and issue template
- UserWarnings are not Errors
- Leave example notebooks unexecuted in the repo
- Pam Fix Plans Crop functionality beyond the last leg/activity
- Bad design of Scorer (it was me)
- Abstractmethod docstrings are not inherited in API reference
- Airspeed Velocity benchmarking HOT 1
- wrong type conversion of type conversions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pam.