Git Product home page Git Product logo

Comments (4)

chicken-teriyaki-cup-rice avatar chicken-teriyaki-cup-rice commented on June 14, 2024 1

Can I try doing this? Here is my first ever pull request on OSS.
Checked docs -> Code added -> Actual result is expected result.
image

from pam.

mfitz avatar mfitz commented on June 14, 2024

Hi @chicken-teriyaki-cup-rice

Thanks for your contribution! I've added a couple of reviewers to your pull request so we can see about getting it merged.

A couple of small pointers:

1 - You can link PRs to the issue they solve. This is a good thing to do, because then anybody looking at the issue will see that there is a potential fix waiting in a PR, plus the issue will automatically be closed when the PR is merged. I've manually linked the issue for you.

2 - Supplying a screenshot of the new behaviour as you have done above is always a good idea 👍 . However, it's better to have that on the pull request itself, rather than here on the issue. Your PR might include a before and after, where you show the old output from pam --help, the output from pam --help after your change, and the output from pam --version

from pam.

chicken-teriyaki-cup-rice avatar chicken-teriyaki-cup-rice commented on June 14, 2024

Thanks for the tips! I added the before, after, and actual_output screenshots on the pull request itself.

from pam.

chicken-teriyaki-cup-rice avatar chicken-teriyaki-cup-rice commented on June 14, 2024

Applied the requested changes from #161 to #174.

from pam.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.