Git Product home page Git Product logo

Comments (2)

arturovm avatar arturovm commented on June 21, 2024

Yeah :| I'm still trying to decide what's the best strategy for implementing the first–time setup.

  1. it opens up a vulnerability where anybody from the internet, prior the running the first time setup, can create an admin–level user and hijack the server
  2. it just doesn't make much sense as it is... plus, the check the server does to determine if you can run the first–time setup is a bit hacky (basically it just queries the database for users and if the query returns more than 0 rows, it returns HTTP status 401)

The first–time setup page is hard–coded into the Go program, to have control over when it is displayed and when it is not (the other alternative is JavaScript and Angular partials, but users can always use "View Source").

A temporary solution to the link problem, is to add extra checks to the log in page Angular controller.

from epitome.

jeena avatar jeena commented on June 21, 2024

I don't see a problem with the 401, the check must be done if someone tries to get the resource, and it doesn't matter if it is because they clicked on a link or they wrote the url to the browser/curl. The hiding of the link is just to have a better ui, so using JS to do that is ok.

from epitome.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.