Comments (1)
Interesting. Anything less than 1s is largely meaningless for most applications so casting or rounding to an integer is likely the right solution. Given the mixed input of Laravel's Cache interface, it would be nice that their implementation standardized a non-integer input or threw an exception to match the docblock expectations when a float is passed. Then this driver specific error wouldn't bubble up. I'll make the proposed change and tag.
from ratelimiter.
Related Issues (10)
- Logo Design HOT 1
- User-Resolver: sha1() expects parameter 1 to be string, int given HOT 1
- All routes and users are spammed with response error 429 HOT 1
- Setting 24 hour rate limit HOT 1
- Configuring a global & route limit HOT 2
- Possible to tag a release? HOT 5
- Setting limits that aren't per second HOT 2
- Timeout TTL set incorrectly HOT 2
- Hit TTL potentially set incorrectly... HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ratelimiter.