Comments (5)
You speak about no line break between the tags?
from seotools.
hey how setup code
from seotools.
I created a pull request for this.
from seotools.
This is certainly not a problem this package should solve. It is however a
problem this package creates. It generates 20+ lines of code in some cases,
all of which just meta info. For that to be unminified it absolutely
unacceptable for an SEO plugin. This package has the potential to be very
widely used, but it never will until it adheres the MOST important aspect
of SEO: page loading speed. And I understand that minifying code could be
tedious, but my solution has 0 new lines of code. There is no reason NOT to
include it or a variation of it.
On Jun 23, 2016 11:08 PM, "William Oliveira" [email protected]
wrote:
In my opinion I dont think this is a problem this package needs to solve,
if you care about that you should use something that minifies the whole
page, maybe a middleware that minifies the html output or better, something
that minifies the cached views on /storage/framework/views—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#51 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ANLCAEEvqIaUnrbzLxNngMeOTkEqs5Uuks5qO1hJgaJpZM4Hem9x
.
from seotools.
Yeah, I realized right before I sent that my second solution wouldn't work
as the html from this package is created dynamically before the view
caching process, in that case it is a valid problem,
but still, the other solution, minifying the whole page at the end of the
request works
2016-06-24 1:19 GMT-03:00 Jake [email protected]:
This is certainly not a problem this package should solve. It is however a
problem this package creates. It generates 20+ lines of code in some cases,
all of which just meta info. For that to be unminified it absolutely
unacceptable for an SEO plugin. This package has the potential to be very
widely used, but it never will until it adheres the MOST important aspect
of SEO: page loading speed. And I understand that minifying code could be
tedious, but my solution has 0 new lines of code. There is no reason NOT to
include it or a variation of it.
On Jun 23, 2016 11:08 PM, "William Oliveira" [email protected]
wrote:In my opinion I dont think this is a problem this package needs to solve,
if you care about that you should use something that minifies the whole
page, maybe a middleware that minifies the html output or better,
something
that minifies the cached views on /storage/framework/views—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#51 (comment),
or mute the thread
<
https://github.com/notifications/unsubscribe/ANLCAEEvqIaUnrbzLxNngMeOTkEqs5Uuks5qO1hJgaJpZM4Hem9x.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#51 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AGC--CWZV4uw01FOjh1DQjBpks44ofHzks5qO1rngaJpZM4Hem9x
.
from seotools.
Related Issues (20)
- Bump composer.json dependencies to allow for php 8.0+ HOT 2
- Setup new Github workflow /tests
- Bug - `SeoTools::setTitle` not setting `JsonLdMulti` title
- application/ld+json data add auto 0: when i add multiple context HOT 5
- Escape HTML special chars in render like 'Test "quote" > test' HOT 2
- Support for PHP 8.1
- Laravel 10 released HOT 1
- Laravel dependency - Error facade HOT 1
- Documentation - OpenGraph - setProduct missing
- OpenGraph - Missing Product attributes
- I have installed artesaos via composer and published after trying to use it doesnt work, please help me HOT 1
- beforeTitle doen't work HOT 1
- Question: SEO Title Different HOT 1
- Support PHPUnit 10
- Livewire
- Non-static method Artesaos\SEOTools\SEOMeta::setTitle() cannot be called statically HOT 1
- missing attribute for setProduct
- - Root composer.json requires artesaos/seotools ^v0.23.0 -> satisfiable by artesaos/seotools[v0.23.0]. HOT 1
- do this package can cache result HOT 2
- Add support for returning the generated seo as an array of strings. Integration with Inertia.js HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from seotools.