Git Product home page Git Product logo

Comments (4)

jraddaoui avatar jraddaoui commented on August 16, 2024 1

Hi @Jimadine,

Thanks for the analysis and observations. There are no other use case in production that require nodejs nor
npm and I'm not sure why we forced that version at some point. So, as you said, installing only the default npm version should be enough. We'll revisit the PR you mention and add a similar change to the current installation docs for 2.6.x.

from atom-docs.

jraddaoui avatar jraddaoui commented on August 16, 2024 1

Thanks again @Jimadine,

We're going to address this in 2.6 with the following pull request until we implement a better solution for 2.7 (see #163 (comment) for more information).

#183

In the new commit, we're removing the nodejs installation but keeping the make install even if it's not needed in Ubuntu 18.04, just in case someone is following the doc in a different OS, as it may solve some minor headaches.

from atom-docs.

jraddaoui avatar jraddaoui commented on August 16, 2024 1

Sorry for the back and forward @Jimadine, finally addressed in 2.6 (9bbcb2a) and 2.7 (a885d83) with similar fixes. Thanks!

from atom-docs.

jraddaoui avatar jraddaoui commented on August 16, 2024

On second thought, we are planing a new version of the existing themes using Bootstrap 5, which may not come in 2.7. Considering the deployment changes the suggestion and PR above will require, we probably want to wait to do that alongside the B5 upgrade. Considering that the remaining warnings are deprecated options running the Less compiler and that we are using a pinned version already, it shouldn't be a mayor concern.

from atom-docs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.