Problem: extract_file endpont may fail to delete temporary folder about archivematica-storage-service HOT 5 CLOSED

A client has reported that when using NFS and because the file isn't closed then NFS creates a hidden file upon its deletion that prevents rmdir from removing its temp directory.

from archivematica-storage-service.

Related: https://serverfault.com/questions/201294/nfsxxxx-files-appearing-what-are-those.

from archivematica-storage-service.

I'm going to submit a pull request addressing the issue by passing ignore_errors=True to shutil.rmtree. It was suggested to address it in the following way:

f = open(filepath, 'rb')
response = http.FileResponse(f.read())
f.close()

But I want to avoid that because I don't want to read the whole file in memory.

A long-term solution has been suggested in artefactual-labs/am#21 but it's not something we can achieve in the way SS works today.

from archivematica-storage-service.

@sevein how can this be QA'd? Thanks.

from archivematica-storage-service.

This was reproducible only when the Archivematica Shared Directory was a NFS device.

I'm not sure if the QA environment is using NFS. If that was the case, we would need to send requests to the /api/v1/file/<uuid>/extract_file/ endpoint (Storage Service) and verify that it does not throw an error. One of our clients was also able to reproduce this just by creating a new AIC in AM because that workflow was making use of the /api/v1/file/<uuid>/extract_file/ endpoint.

This may require some coordination with @mamedin or @scollazo and tweaks in the QA environment, i.e. NFS drive instead of local filesystem.

from archivematica-storage-service.