Comments (4)
No, sorry, I am not trying to be condescending.
And maybe I did not understand the original problem. Aaaaand, I had no idea you could put quotes around types to forward declare them. Then it makes sense to me :D
from odmantic.
But, that makes sense? :O The embedded model should be defined first so a definition exists?
Also:
class Bar(Model):
bar: "Foo" <------ should lose the quotation marks?
aaaand
[Index(asc(Bar.bar.foo)] <--- missing a parentheses :D :
[Index(asc(Bar.bar.foo))]
from odmantic.
Well as I mentioned, it doesn't matter if the quotations are there or not for both cases, and I didn't test the example code specifically so I missed the parentheses. I just think it should be specified in the documentation because it's not obvious that it should be defined before (other odm libraries don't have this behavior).
When you say "the embedded model should be defined first so a definition exists," that should (intuitively) only be necessary for the type hint if you want to define it without quotations. The reason I say it's not intuitive or obvious is because by the time any code is run regarding creating indexes or creating search queries, both of the models have already been defined.
I'm not saying the behavior is bad, it just needs to be clarified somewhere, and it might be unintended.
from odmantic.
Also, what's with the unnecessary condescension? You clearly didn't take the time to fully understand the original post.
from odmantic.
Related Issues (20)
- Support for Optional types as X | None HOT 1
- Question: how to mock/write propper unittests HOT 2
- when a model has many optional field, it will raise unwanted validation type error HOT 4
- Odmantic Does Not Add Pydantic Computed Fields to MongoDB HOT 2
- Aggregation support via the find method HOT 2
- Datetime not updating and not updating frequently
- Injected Context for Model Class not picked up
- Unexpected @field_validator behaviour
- ODMantic is incompatible with pydantic version 2.7.0 HOT 4
- Custom fields serialisation & deserialisation HOT 1
- Motor uses ThreadPoolExecutor, it drastically decreases a performance HOT 4
- `key_name` doesn't work when field is `id` HOT 2
- The "Custom field types" doc talks about a __bson__ method with an example that doesn't include it
- Field support exclud
- __bson__ serialization does not work when Optional / Union used with Custom Types
- Can't save a model with a field of type pydantic.AnyUrl
- Optional Embedded model and key_name not working HOT 6
- Using Model.model_construct breaks attr setters
- High Memory Usage when Iterating over cursor with many document
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from odmantic.