Git Product home page Git Product logo

Comments (7)

Beast-Monk avatar Beast-Monk commented on July 23, 2024 1

There are the 3 styling guides I found :

AirBnB Style guide (JS/React) : https://github.com/airbnb/javascript
Google Style guide (JS) : https://google.github.io/styleguide/jsguide.html
Khan Academy Style guide (React) : https://github.com/Khan/style-guides/blob/master/style/react.md#open-elements-on-the-same-line

I believe AirBnB one is a comprehensive one as we have style guides for all frontend (JS/React/Css in JS/SAAS) in the same repo.

For the Google style guide, it is already in the Hyperlink @line-no:31 "style guides", within its combined style guide repo.

Lets vote for the preference, I vote for AirBnB one !
[Also, please assign this issue to me]

from starterhive.

ArslanYM avatar ArslanYM commented on July 23, 2024

@Sohoxic Could you provide the correct link for this? Then @tanbirali can start working on it

from starterhive.

Beast-Monk avatar Beast-Monk commented on July 23, 2024

Hi, there is an trailing Quotation mark (") or its equivalent (%22) in the hyperlink URI.
I have corrected that and shared a PR: #83.

Btw, I have a question : Since this is a styling guide for Python, are you sure this is the intent for the hyperlink ?
Kindly review @ArslanYM & @tanbirali, this is my first Open-source PR !
:)

from starterhive.

ArslanYM avatar ArslanYM commented on July 23, 2024

@Beast-Monk Youre right , The styling guide should be for Javascript or React.

from starterhive.

ArslanYM avatar ArslanYM commented on July 23, 2024

@Beast-Monk I have merged the PR since it was your first one!! Congratulations.
Yet, I would love to change it from python to Javascript coding style. Can you make the changes?

from starterhive.

ArslanYM avatar ArslanYM commented on July 23, 2024

There are the 3 styling guides I found :

AirBnB Style guide (JS/React) : https://github.com/airbnb/javascript Google Style guide (JS) : https://google.github.io/styleguide/jsguide.html Khan Academy Style guide (React) : https://github.com/Khan/style-guides/blob/master/style/react.md#open-elements-on-the-same-line

I believe AirBnB one is a comprehensive one as we have style guides for all frontend (JS/React/Css in JS/SAAS) in the same repo.

For the Google style guide, it is already in the Hyperlink @line-no:31 "style guides", within its combined style guide repo.

Lets vote for the preference, I vote for AirBnB one ! [Also, please assign this issue to me]

I vote for the same.
Great research.
Assigned to you.

from starterhive.

Beast-Monk avatar Beast-Monk commented on July 23, 2024

Done from my end.

Please review the commit & let me know.

from starterhive.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.